From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#15200: isearch-other-meta-char and shift Date: Mon, 16 Sep 2013 22:19:02 -0400 Message-ID: References: <8761urkssh.fsf@mail.jurta.org> <87fvtvgk00.fsf@mail.jurta.org> <877gf5rcoz.fsf@mail.jurta.org> <87wqn53sac.fsf@mail.jurta.org> <87vc2k7556.fsf@mail.jurta.org> <87txhko1mb.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1379384423 29496 80.91.229.3 (17 Sep 2013 02:20:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Sep 2013 02:20:23 +0000 (UTC) Cc: 15200@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 17 04:20:26 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VLkts-0001Ly-Dy for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Sep 2013 04:20:24 +0200 Original-Received: from localhost ([::1]:37775 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLktr-00089P-GM for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Sep 2013 22:20:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLkth-00088E-Dw for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2013 22:20:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VLktW-0002Ul-VE for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2013 22:20:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLktW-0002U9-S8 for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2013 22:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VLktV-0003U3-UV for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2013 22:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Sep 2013 02:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15200 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15200-submit@debbugs.gnu.org id=B15200.137938436613334 (code B ref 15200); Tue, 17 Sep 2013 02:20:01 +0000 Original-Received: (at 15200) by debbugs.gnu.org; 17 Sep 2013 02:19:26 +0000 Original-Received: from localhost ([127.0.0.1]:42375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VLksv-0003Sz-4W for submit@debbugs.gnu.org; Mon, 16 Sep 2013 22:19:25 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:18243) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VLkss-0003Sj-OS for 15200@debbugs.gnu.org; Mon, 16 Sep 2013 22:19:23 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFG4rxBo/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2OLoJcA6R6gV6Caik X-IPAS-Result: Av4EABK/CFG4rxBo/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2OLoJcA6R6gV6Caik X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="28100118" Original-Received: from 184-175-16-104.dsl.teksavvy.com (HELO pastel.home) ([184.175.16.104]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 16 Sep 2013 22:15:27 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 481D362DA7; Mon, 16 Sep 2013 22:19:02 -0400 (EDT) In-Reply-To: <87txhko1mb.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 17 Sep 2013 01:09:36 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78476 Archived-At: > This happens after this code: > (memq scroll-command > '(universal-argument > negative-argument digit-argument)))))) > (command-execute scroll-command) This code can be simplified as follows: `scroll-command' can be removed, instead its value is immediately available as `this-command'. > Perhaps `command-execute' should be removed here. Indeed. For isearch-allow-prefix, that's all that's needed. > It's not yet removed in this patch since I'm not sure > because after moving its post-processing code: > (let ((ab-bel (isearch-string-out-of-window isearch-point))) > (if ab-bel > (isearch-back-into-window (eq ab-bel 'above) isearch-point) > (goto-char isearch-point))) Yes, this needs to be moved to post-command-hook. Another alternative is to do something like (setq this-command `(lambda () (interactive) (let ((isearch-point (point))) (command-execute ',this-command) (let ((ab-bel (isearch-string-out-of-window isearch-point))) (if ab-bel (isearch-back-into-window (eq ab-bel 'above) isearch-point) (goto-char isearch-point)))))) but this is probably going to bring us more trouble than it's worth. Stefan