From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 15880@debbugs.gnu.org
Subject: bug#15880: Compute C declarations for DEFSYMs automatically.
Date: Wed, 13 Nov 2013 19:26:08 -0500 [thread overview]
Message-ID: <jwvob5n96py.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <5283A805.7030609@cs.ucla.edu> (Paul Eggert's message of "Wed, 13 Nov 2013 08:25:41 -0800")
>> I was thinking of doing it only for the DEFSYMs (which would obviously
>> need to be kept in a separate file).
> There still might be problems with existing symbols that are not
> DEFSYMed. For example, suppose we add 'DEFSYM (Qprotected_field,
> "protected-field");' to window.c. The new include file will be rebuilt
> and only window.c will be recompiled, and 'make' will succeed. But
> buffer.c (which declares Qprotected_field as a static var and
> defines it by hand) will disagree with window.c about where
> Qprotected_field is, so Emacs might not work right, and the
> problems might be hard to find and diagnose.
Doesn't sound like a serious problem to me. The two variables have the
same name and same content and are read-only, so the redundancy is harmless.
> Second, preallocate each DEFSYM's struct Lisp_Symbol, so that its
> address is known at link-time.
Not sure the performance impact would be significant. But I'm not
opposed to such a change.
As for the other change: ideally, I'd like to get rid of DEFSYM and
introduce instead a new macro that would replace:
... Qfoo_bar ...
syms_of_bar ()
{
...
DEFSYM (Qfoo_bar, "foo-bar");
...
}
with
... INTERN ("foo-bar") ...
syms_of_bar ()
{
...
/* nothing here */
...
}
Now, I don't think we could do it with INTERN("foo-bar"). But we could
probably do it with:
... INTERN (Qfoo_bar) ...
syms_of_bar ()
{
...
/* nothing here */
...
}
such that make-docfile finds the "INTERN", infers the Lisp name from the
C name and writes a "syms.c" file which does little else but initialize
all those symbols.
Stefan
next prev parent reply other threads:[~2013-11-14 0:26 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 0:33 bug#15880: Compute C declarations for DEFSYMs automatically Paul Eggert
2013-11-13 3:54 ` Eli Zaretskii
2013-11-13 5:00 ` Paul Eggert
2013-11-13 4:19 ` Stefan Monnier
2013-11-13 5:12 ` Paul Eggert
2013-11-13 13:36 ` Stefan Monnier
2013-11-13 16:25 ` Paul Eggert
2013-11-14 0:26 ` Stefan Monnier [this message]
2013-11-14 1:32 ` Paul Eggert
2013-11-14 2:29 ` Stefan Monnier
2013-11-14 4:13 ` Paul Eggert
2013-11-14 5:06 ` Stefan Monnier
2013-11-14 5:26 ` Paul Eggert
2013-11-14 16:28 ` Eli Zaretskii
2013-11-14 20:25 ` Paul Eggert
2013-11-15 7:59 ` Eli Zaretskii
2013-11-15 13:58 ` Stefan Monnier
2013-11-13 16:07 ` Eli Zaretskii
2013-11-13 22:00 ` Stefan Monnier
2013-11-14 3:47 ` Eli Zaretskii
2013-11-14 4:59 ` Stefan Monnier
2013-11-14 16:29 ` Eli Zaretskii
2014-12-20 1:55 ` Paul Eggert
2014-12-23 17:15 ` Stefan Monnier
2014-12-23 23:51 ` Paul Eggert
2015-01-05 16:51 ` Stefan Monnier
2015-01-05 17:25 ` Paul Eggert
2015-01-05 17:55 ` Stefan Monnier
2015-01-05 18:17 ` Paul Eggert
2015-01-05 18:56 ` Eli Zaretskii
2015-01-05 19:24 ` Paul Eggert
2015-01-05 19:48 ` Eli Zaretskii
2015-01-05 22:20 ` Paul Eggert
2015-01-06 3:28 ` Eli Zaretskii
2015-01-07 21:48 ` Glenn Morris
2015-01-08 1:16 ` Paul Eggert
2015-01-08 13:28 ` Eli Zaretskii
2015-01-09 16:33 ` Paul Eggert
2015-01-09 20:06 ` Eli Zaretskii
2015-01-09 20:08 ` Andreas Schwab
2015-01-09 20:50 ` Eli Zaretskii
2015-01-09 21:10 ` Andreas Schwab
2015-01-09 21:48 ` Stefan Monnier
2015-01-10 11:30 ` Eli Zaretskii
2015-01-05 19:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvob5n96py.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=15880@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.