From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Bozhidar Batsov <bozhidar@batsov.com>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: [ruby-mode] Private/protected method definition layout in Ruby 2.1
Date: Wed, 15 Jan 2014 13:51:14 -0500 [thread overview]
Message-ID: <jwvob3dulmb.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87lhyh2jo4.fsf@yandex.ru> (Dmitry Gutov's message of "Wed, 15 Jan 2014 20:18:19 +0200")
> `private' is a method, called with the expression `def ... end`.
Ah, that makes sense.
> I believe we can also handle this in the rules-function. Add a new rule
> for (:before . "def"), see if the preceding token is one of `private',
> `public', `protected', and if so, indent to its beginning column.
If that's works, it's preferable, indeed. Especially in light of the
above (i.e. changing the parsing would be wrong).
> Can we install such a change, with either of the approaches, during the
> feature freeze?
I think it's OK, yes. We're not yet in the "regression-only" phase.
Stefan
next prev parent reply other threads:[~2014-01-15 18:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 14:41 [ruby-mode] Private/protected method definition layout in Ruby 2.1 Bozhidar Batsov
2014-01-15 16:24 ` Stefan Monnier
2014-01-15 18:18 ` Dmitry Gutov
2014-01-15 18:51 ` Stefan Monnier [this message]
2014-01-16 5:47 ` Dmitry Gutov
2014-01-16 10:15 ` Bozhidar Batsov
2014-01-16 13:37 ` Dmitry Gutov
2014-01-16 14:26 ` Bozhidar Batsov
2014-01-16 18:40 ` Dmitry Gutov
2014-01-16 19:38 ` Bozhidar Batsov
2014-01-17 3:17 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvob3dulmb.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bozhidar@batsov.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.