From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17970: log-edit creates unwanted ChangeLog buffers Date: Wed, 09 Jul 2014 14:54:57 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1404932196 4813 80.91.229.3 (9 Jul 2014 18:56:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Jul 2014 18:56:36 +0000 (UTC) Cc: 17970-done@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 09 20:56:29 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X4x2Z-00052y-4R for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Jul 2014 20:56:27 +0200 Original-Received: from localhost ([::1]:33262 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4x2Y-00011T-PN for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Jul 2014 14:56:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4x2J-0000zP-QV for bug-gnu-emacs@gnu.org; Wed, 09 Jul 2014 14:56:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4x2B-0003Qs-H2 for bug-gnu-emacs@gnu.org; Wed, 09 Jul 2014 14:56:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4x2B-0003Qm-Do for bug-gnu-emacs@gnu.org; Wed, 09 Jul 2014 14:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X4x2B-0006Vc-7o for bug-gnu-emacs@gnu.org; Wed, 09 Jul 2014 14:56:03 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Jul 2014 18:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 17970 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 17970@debbugs.gnu.org, monnier@iro.umontreal.ca, rgm@gnu.org Original-Received: via spool by 17970-done@debbugs.gnu.org id=D17970.140493212824951 (code D ref 17970); Wed, 09 Jul 2014 18:56:02 +0000 Original-Received: (at 17970-done) by debbugs.gnu.org; 9 Jul 2014 18:55:28 +0000 Original-Received: from localhost ([127.0.0.1]:48077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4x1a-0006UL-MK for submit@debbugs.gnu.org; Wed, 09 Jul 2014 14:55:27 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:39539) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X4x1X-0006UC-Al for 17970-done@debbugs.gnu.org; Wed, 09 Jul 2014 14:55:23 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 39E3984E39; Wed, 9 Jul 2014 14:55:22 -0400 (EDT) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 515731E5B74; Wed, 9 Jul 2014 14:54:57 -0400 (EDT) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 1AB62B4167; Wed, 9 Jul 2014 14:54:57 -0400 (EDT) In-Reply-To: (Glenn Morris's message of "Mon, 07 Jul 2014 22:35:39 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91336 Archived-At: > C-x C-b -> Now there is an empty, unwanted "/tmp/foo/ChangeLog" buffer. I installed the patch below which seems to fix this problem. Stefan === modified file 'lisp/vc/log-edit.el' --- lisp/vc/log-edit.el 2014-07-01 15:15:03 +0000 +++ lisp/vc/log-edit.el 2014-07-09 18:52:47 +0000 @@ -905,6 +905,7 @@ ;; that memoizing which is undesired here. (setq change-log-default-name nil) (find-change-log))))) + (when (file-exists-p changelog-file-name) (with-current-buffer (find-file-noselect changelog-file-name) (unless (eq major-mode 'change-log-mode) (change-log-mode)) (goto-char (point-min)) @@ -942,7 +943,7 @@ (setq pos (max (1+ pos) (elt entry 1))) (goto-char pos))) - (cons (current-buffer) texts)))))))) + (cons (current-buffer) texts))))))))) (defun log-edit-changelog-insert-entries (buffer beg end &rest files) "Insert the text from BUFFER between BEG and END.