From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#19102: 24.4; outline-move-subtree-up/down error at last and second-last subtree Date: Wed, 26 Nov 2014 10:54:19 -0500 Message-ID: References: <87lhn7s522.fsf@rosalinde.fritz.box> <83lhn789tq.fsf@gnu.org> <87h9xvruan.fsf@rosalinde.fritz.box> <83tx1v6mur.fsf@gnu.org> <87a93nrlql.fsf@rosalinde.fritz.box> <83lhn76iex.fsf@gnu.org> <8761easv3s.fsf@rosalinde.fritz.box> <8761e26q12.fsf@rosalinde.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1417017331 28627 80.91.229.3 (26 Nov 2014 15:55:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Nov 2014 15:55:31 +0000 (UTC) Cc: paul@tilk.co, 19102@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 26 16:55:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xtew7-0006ta-Dv for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Nov 2014 16:55:23 +0100 Original-Received: from localhost ([::1]:34485 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtew7-0000dX-1T for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Nov 2014 10:55:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtevu-0000W0-Qn for bug-gnu-emacs@gnu.org; Wed, 26 Nov 2014 10:55:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xtevn-0007gL-C9 for bug-gnu-emacs@gnu.org; Wed, 26 Nov 2014 10:55:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xtevn-0007fQ-8K for bug-gnu-emacs@gnu.org; Wed, 26 Nov 2014 10:55:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Xtevm-0001Jg-RF for bug-gnu-emacs@gnu.org; Wed, 26 Nov 2014 10:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Nov 2014 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19102 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19102-submit@debbugs.gnu.org id=B19102.14170172635003 (code B ref 19102); Wed, 26 Nov 2014 15:55:02 +0000 Original-Received: (at 19102) by debbugs.gnu.org; 26 Nov 2014 15:54:23 +0000 Original-Received: from localhost ([127.0.0.1]:46357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xtev8-0001Id-Qu for submit@debbugs.gnu.org; Wed, 26 Nov 2014 10:54:23 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:48653) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xtev7-0001IW-ET for 19102@debbugs.gnu.org; Wed, 26 Nov 2014 10:54:21 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id sAQFsJ66000937; Wed, 26 Nov 2014 10:54:19 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 20C6A4820; Wed, 26 Nov 2014 10:54:19 -0500 (EST) In-Reply-To: <8761e26q12.fsf@rosalinde.fritz.box> (Stephen Berman's message of "Wed, 26 Nov 2014 14:38:01 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5137=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5137> : inlines <1562> : streams <1349015> : uri <1836228> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96619 Archived-At: > Oops, you commented on the last version of my patch, which, however, I > had already considered superseded by the last version of the command > subsequently posted by Paul Rankin, which in effect already addressed > your concerns. Rather than repost the diff for the latter, I'm > appending the two corrected versions of outline-move-subtree-down to > facilitate comparison and deciding which to use. Please just send the diff that (you think) should be applied. Or two diffs to apply in sequence if you want to distinguish your changes from Paul's. > The only thing I added to both is a condition for triggering the > user-error, since the message doesn't seem appropriate when you try to > move a subtree down at eob or up at bob (if you don't think it's worth > avoiding the message there, I'll remove the condition). I don't see why we should avoid the error in those cases: AFAICT, we can't do what the user asked, so we should signal an error. Stefan