From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master b843370: * packages/other-frame-window/other-frame-window.el: New single-file package. Date: Sat, 15 Aug 2015 17:50:03 -0400 Message-ID: References: <20150814050452.7700.48557@vcs.savannah.gnu.org> <86vbcgtpr8.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1439675423 17001 80.91.229.3 (15 Aug 2015 21:50:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 15 Aug 2015 21:50:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 15 23:50:14 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZQjLA-0006CT-BB for ged-emacs-devel@m.gmane.org; Sat, 15 Aug 2015 23:50:12 +0200 Original-Received: from localhost ([::1]:50873 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQjL9-0005IP-Lg for ged-emacs-devel@m.gmane.org; Sat, 15 Aug 2015 17:50:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQjL6-0005GD-H1 for emacs-devel@gnu.org; Sat, 15 Aug 2015 17:50:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQjL3-00045r-9k for emacs-devel@gnu.org; Sat, 15 Aug 2015 17:50:08 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:54395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQjL3-00044E-6E for emacs-devel@gnu.org; Sat, 15 Aug 2015 17:50:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CtCwA731xV/5P+d0tcgxCEAsEMCYdLBAICgTw5FAEBAQEBAQGBCkEFg10BAQRWIxALNAcLFBgNJIg/zyMBAQEBBgEBAQEeizqFBQeELQWZbgWZTIFFI4FmVYFZIoJ4AQEB X-IPAS-Result: A0CtCwA731xV/5P+d0tcgxCEAsEMCYdLBAICgTw5FAEBAQEBAQGBCkEFg10BAQRWIxALNAcLFBgNJIg/zyMBAQEBBgEBAQEeizqFBQeELQWZbgWZTIFFI4FmVYFZIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="160236677" Original-Received: from 75-119-254-147.dsl.teksavvy.com (HELO pastel.home) ([75.119.254.147]) by ironport2-out.teksavvy.com with ESMTP; 15 Aug 2015 17:50:03 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id A67C961629; Sat, 15 Aug 2015 17:50:03 -0400 (EDT) In-Reply-To: <86vbcgtpr8.fsf@stephe-leake.org> (Stephen Leake's message of "Sat, 15 Aug 2015 12:39:39 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188809 Archived-At: > ;; FIXME: This is basically the union of the default C-x 4 and C-x 5 > ;; keymaps in Emacs-25. > Is the point of this FIXME: that eventually this could replace the C-x 4 > and C-x 5 keymaps? Good question. I think it was a mistake. I probably started to write "FIXME:" because I wanted to document the problem of the "dwim" commands, which are somewhat ugly, but then I went ahead and wrote those dwim commands and decided it wasn't that bad. So the end result is a doc that isn't really a FIXME but which starts with "FIXME:". > - Why is (remove-hook 'pre-command-hook #'ofw--reset-prefix) before the > 'if', instead of in the else branch? I like to write minor modes such that they always begin by cleaning up first and then, if requested, adding what needs to be added. I think in the case of global hooks it makes no difference, but for a few other cases it avoids adding stuff twice or having to check whether the mode was already enabled or something. Stefan