From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change f59d1be: Move undo amalgamation to lisp. Date: Thu, 29 Oct 2015 11:47:29 -0400 Message-ID: References: <20151005134118.10933.50859@vcs.savannah.gnu.org> <87h9m52sh8.fsf@russet.org.uk> <87h9lqbk8m.fsf@russet.org.uk> <87mvvc9g3m.fsf@russet.org.uk> <87wpu8lbtp.fsf@russet.org.uk> <87io5r5n2d.fsf@russet.org.uk> <87a8r13fal.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1446133670 6516 80.91.229.3 (29 Oct 2015 15:47:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 29 Oct 2015 15:47:50 +0000 (UTC) Cc: emacs-devel@gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 29 16:47:41 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZrpQS-0007l9-Oa for ged-emacs-devel@m.gmane.org; Thu, 29 Oct 2015 16:47:40 +0100 Original-Received: from localhost ([::1]:44858 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrpQS-0007jx-4s for ged-emacs-devel@m.gmane.org; Thu, 29 Oct 2015 11:47:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrpQN-0007jK-A9 for emacs-devel@gnu.org; Thu, 29 Oct 2015 11:47:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrpQJ-0004xj-TW for emacs-devel@gnu.org; Thu, 29 Oct 2015 11:47:35 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:44499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrpQJ-0004xN-QV for emacs-devel@gnu.org; Thu, 29 Oct 2015 11:47:31 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CVDQA731xV/+Z93mhcgxCEAsEVh0sEAgKBPDsSAQEBAQEBAYEKQQWDXQEBAwFWIxALNAcLFBgNiFsIzyMBAQgCAR+LOoUFB4QtAQSfF5IUg1kjgjuBWSKCeAEBAQ X-IPAS-Result: A0CVDQA731xV/+Z93mhcgxCEAsEVh0sEAgKBPDsSAQEBAQEBAYEKQQWDXQEBAwFWIxALNAcLFBgNiFsIzyMBAQgCAR+LOoUFB4QtAQSfF5IUg1kjgjuBWSKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="171984454" Original-Received: from 104-222-125-230.cpe.teksavvy.com (HELO fmsmemgm.homelinux.net) ([104.222.125.230]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 29 Oct 2015 11:47:29 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 842F7AE25E; Thu, 29 Oct 2015 11:47:29 -0400 (EDT) In-Reply-To: <87a8r13fal.fsf@russet.org.uk> (Phillip Lord's message of "Thu, 29 Oct 2015 14:44:34 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192907 Archived-At: >> for us to hit the first key) should call undo-auto-boundaries (assuming >> your patch indeed calls undo-auto-boundaries *before* rather than >> *after* running the command). > At the moment, it's more *after* rather than *before*. The old code does it before. See, you just got bitten because you gratuitously changed that ;-) Stefan