From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Thomas Fitzsimmons <fitzsim@fitzsim.org>
Cc: "Fabián E. Gallina" <fgallina@gnu.org>, emacs-devel@gnu.org
Subject: Re: [elpa] master 872014e: Prevent accidental deletion of .git
Date: Mon, 09 Nov 2015 00:03:34 -0500 [thread overview]
Message-ID: <jwvoaf3ix7u.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <m3vb9b93qg.fsf@fitzsim.org> (Thomas Fitzsimmons's message of "Sun, 08 Nov 2015 23:49:27 -0500")
>> Once we change the handling of :core in elpa/admin/archive-contents.el
>> so that it sets up symlinks rather than performing copies, we should at
>> least be able to make the deletion less dangerous, e.g. by only deleting
>> symlinks and empty directories (so even if the deletion was erroneous,
>> no actual file contents was destroyed along the way).
>> Fabián, any news on this?
> Arthur pointed out in another thread that this code is at least
> partially there already (I haven't heard from Fabián about its status).
Right, Fabian installed its code already, but I found out at that point
that the way it works (i.e copying files from emacs.git) is problematic
in various ways: it should instead setup symlinks.
> The attached patch seems to work
Yes, it kinda works but it suffers from various warts (e.g. "make
externals; make" will always recompile all the :core packages).
> with a locally-generated archive, but it introduces the first external
> to make use of :core. Should I push it and see what happens?
No, we should change to code to use symlinks instead of
file-copies first (and at the same time change it as I suggested,
i.e. to only delete symlinks and empty directories).
Stefan
next prev parent reply other threads:[~2015-11-09 5:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151109013124.17711.29422@vcs.savannah.gnu.org>
[not found] ` <E1ZvbIq-0004cL-VV@vcs.savannah.gnu.org>
2015-11-09 1:58 ` [elpa] master 872014e: Prevent accidental deletion of .git Stefan Monnier
2015-11-09 4:49 ` Thomas Fitzsimmons
2015-11-09 5:03 ` Stefan Monnier [this message]
2015-11-09 16:07 ` Eli Zaretskii
2015-11-09 16:38 ` Artur Malabarba
2015-11-09 16:45 ` Eli Zaretskii
2015-11-09 20:20 ` Stefan Monnier
2015-11-18 14:39 ` Thomas Fitzsimmons
2015-11-18 15:10 ` Stefan Monnier
2015-11-18 16:44 ` Stephen Leake
2015-11-18 17:35 ` Eli Zaretskii
2015-11-26 3:08 ` Thomas Fitzsimmons
2015-11-26 3:55 ` Stefan Monnier
2015-11-26 14:34 ` Thomas Fitzsimmons
2015-11-26 15:42 ` Stefan Monnier
2015-11-27 6:58 ` Thomas Fitzsimmons
2015-11-27 15:27 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvoaf3ix7u.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=fgallina@gnu.org \
--cc=fitzsim@fitzsim.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.