From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Lisp watchpoints Date: Sun, 29 Nov 2015 20:14:48 -0500 Message-ID: References: <83wpt922dn.fsf@gnu.org> <87bnadjb7o.fsf@igel.home> <83lh9gokfm.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1448846119 17993 80.91.229.3 (30 Nov 2015 01:15:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 30 Nov 2015 01:15:19 +0000 (UTC) Cc: John Wiegley , Eli Zaretskii , Andreas Schwab , emacs-devel@gnu.org To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 30 02:15:06 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a3D3Z-0006Ap-BF for ged-emacs-devel@m.gmane.org; Mon, 30 Nov 2015 02:15:05 +0100 Original-Received: from localhost ([::1]:38445 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3D3d-0004bJ-JW for ged-emacs-devel@m.gmane.org; Sun, 29 Nov 2015 20:15:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3D3P-0004bA-My for emacs-devel@gnu.org; Sun, 29 Nov 2015 20:14:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3D3O-0007A9-Ss for emacs-devel@gnu.org; Sun, 29 Nov 2015 20:14:55 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:52373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3D3K-00077P-4j; Sun, 29 Nov 2015 20:14:50 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CtCwA731xV/yr292hcgxCEAsEMCYdLBAICgTw5FAEBAQEBAQGBCkEFg10BAQMBViMFCwsOJhIUGA0kiDcIzyMBAQEHAQEBAR6LOoUFB4QtBYwwqFQjgWaCMCCCeAEBAQ X-IPAS-Result: A0CtCwA731xV/yr292hcgxCEAsEMCYdLBAICgTw5FAEBAQEBAQGBCkEFg10BAQMBViMFCwsOJhIUGA0kiDcIzyMBAQEHAQEBAR6LOoUFB4QtBYwwqFQjgWaCMCCCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="179716535" Original-Received: from 104-247-246-42.cpe.teksavvy.com (HELO fmsmemgm.homelinux.net) ([104.247.246.42]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 29 Nov 2015 20:14:49 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 805BBAE07A; Sun, 29 Nov 2015 20:14:48 -0500 (EST) In-Reply-To: (Noam Postavsky's message of "Sun, 29 Nov 2015 19:57:05 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195593 Archived-At: >>> > Ffuncall does all necessary checks. >>> >>> It would signal in case of error right? Currently the code is ignoring >>> bad watcher elements (including out of range integers), but perhaps >>> it's actually better to signal an error. >> >> No, I think it would be better to report an error, and then continue, >> perhaps after removing the watch. > I'm thinking to just call display-warning then (removing the element > looks like too much work to be worthwhile, having to modify the list > while iterating over it is kind of annoying). I don't think we should do anything different for the case where Ffuncall signals an error because the object is not a function than for the case where the object *is* a function but its execution signals some kind of error. And the function may want to signal `setting-constant', so I think we're better off just not trying to catch an error there at all. Stefan