From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 3f06795: Migrate auth-source to cl-lib Date: Sat, 12 Nov 2016 17:57:27 -0500 Message-ID: References: <20161102191026.12915.33007@vcs.savannah.gnu.org> <20161102191027.3BAA0220149@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1478992208 27455 195.159.176.226 (12 Nov 2016 23:10:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 12 Nov 2016 23:10:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: Mark Oteiza To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 13 00:10:04 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5hQf-00040Y-BL for ged-emacs-devel@m.gmane.org; Sun, 13 Nov 2016 00:09:45 +0100 Original-Received: from localhost ([::1]:59940 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5hQg-0001bb-M7 for ged-emacs-devel@m.gmane.org; Sat, 12 Nov 2016 18:09:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5hQW-0001aj-4l for emacs-devel@gnu.org; Sat, 12 Nov 2016 18:09:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c5hQR-0000Wk-3E for emacs-devel@gnu.org; Sat, 12 Nov 2016 18:09:36 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:53241) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c5hQQ-0000VK-UZ for emacs-devel@gnu.org; Sat, 12 Nov 2016 18:09:31 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DgBQALW9BX/yuZs2tdGwEBAQMBAQGDLQEBAQEBHoRNhVCxeYYWBAICgWk9EAECAQEBAQEBAV4nhGIBAQRWIxALNBIUGA2JAbxVAQEBBwIBJIp9hQyFEAWOJ3aKPJkNhguQSzUfhG4ehgoBAQE X-IPAS-Result: A0DgBQALW9BX/yuZs2tdGwEBAQMBAQGDLQEBAQEBHoRNhVCxeYYWBAICgWk9EAECAQEBAQEBAV4nhGIBAQRWIxALNBIUGA2JAbxVAQEBBwIBJIp9hQyFEAWOJ3aKPJkNhguQSzUfhG4ehgoBAQE X-IronPort-AV: E=Sophos;i="5.30,296,1470715200"; d="scan'208";a="279144866" Original-Received: from 107-179-153-43.cpe.teksavvy.com (HELO pastel.home) ([107.179.153.43]) by smtp.teksavvy.com with ESMTP; 12 Nov 2016 18:09:27 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id E97C864F63; Sat, 12 Nov 2016 17:57:27 -0500 (EST) In-Reply-To: <20161102191027.3BAA0220149@vcs.savannah.gnu.org> (Mark Oteiza's message of "Wed, 2 Nov 2016 19:10:27 +0000 (UTC)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209364 Archived-At: > @@ -712,7 +712,7 @@ must call it to obtain the actual value." > (plist-get spec key) > (slot-value backend key)) > (setq filtered-backends (delq backend filtered-backends)) > - (return)) > + (cl-return)) > (invalid-slot-name nil)))) Hmm... This change looks right, but I believe there's a bug here: with `cl`, `dolist` is advised to be CL's `dolist` which includes an implicit (block nil ...) wrapper. But with cl-lib, `dolist` is left alone and you need to use `cl-dolist` to get that wrapper. So I think you need to change the surrounding `dolist` to be `cl-dolist` otherwise this `cl-return` will exit from the surrounding function rather than from the inner loop. Stefan