all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Mark Oteiza <mvoteiza@udel.edu>
Subject: Re: [Emacs-diffs] master 3f06795: Migrate auth-source to cl-lib
Date: Sat, 12 Nov 2016 17:57:27 -0500	[thread overview]
Message-ID: <jwvoa1knwax.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20161102191027.3BAA0220149@vcs.savannah.gnu.org> (Mark Oteiza's message of "Wed,  2 Nov 2016 19:10:27 +0000 (UTC)")

> @@ -712,7 +712,7 @@ must call it to obtain the actual value."
>                         (plist-get spec key)
>                         (slot-value backend key))
>                  (setq filtered-backends (delq backend filtered-backends))
> -                (return))
> +                (cl-return))
>              (invalid-slot-name nil))))

Hmm... This change looks right, but I believe there's a bug here:
with `cl`, `dolist` is advised to be CL's `dolist` which includes an
implicit (block nil ...) wrapper.  But with cl-lib, `dolist` is left alone
and you need to use `cl-dolist` to get that wrapper.

So I think you need to change the surrounding `dolist` to be `cl-dolist`
otherwise this `cl-return` will exit from the surrounding function
rather than from the inner loop.


        Stefan



  parent reply	other threads:[~2016-11-12 22:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161102191026.12915.33007@vcs.savannah.gnu.org>
     [not found] ` <20161102191027.3BAA0220149@vcs.savannah.gnu.org>
2016-11-02 20:06   ` [Emacs-diffs] master 3f06795: Migrate auth-source to cl-lib Stefan Monnier
2016-11-02 20:16     ` Mark Oteiza
2016-11-04 18:14       ` Ted Zlatanov
2016-11-04 18:20         ` Mark Oteiza
2016-11-12 22:57   ` Stefan Monnier [this message]
2016-11-13  0:07     ` Mark Oteiza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvoa1knwax.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=mvoteiza@udel.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.