Re: [Emacs-diffs] feature/byte-switch 44c95c5: bytecomp.el: Don't store non-keyword symbols in jump-tables.

[Stefan Monnier <monnier@IRO.UMontreal.CA>]

>  (defun byte-compile-cond-valid-obj2-p (obj)
> -  (if (consp obj)
> -      (and (eq (car obj) 'quote)
> -           (= (length obj) 2)
> -           (symbolp (cadr obj)))
> -    t))
> +  (cond
> +   ((consp obj)
> +    (and (eq (car obj) 'quote)
> +         (= (length obj) 2)
> +         (symbolp (cadr obj))))
> +   ((symbolp obj) (keywordp obj))
> +   (t t)))

I suggest you document the property that you need this to satisfy.
E.g. something like "OBJ is a constant expression whose value can be
compared with `eq`" or something like that.  And you might like to see if
maybe you can use macroexp-const-p in here (there are many different
definitions of "constant", tho).


        Stefan