Re: [elpa] master a179572 3/4: [admin] Specify bash in update-archive.sh shebang line.

Re: [elpa] master a179572 3/4: [admin] Specify bash in update-archive.sh shebang line.

[Stefan Monnier]

>     The program uses several bash-specific constructs.  Although in

Hmm... I thought I'd been careful to avoid them.  Are these uses
significant, or could we easily get rid of them and stick to posix sh?


        Stefan

Re: [elpa] master a179572 3/4: [admin] Specify bash in update-archive.sh shebang line.

[Thien-Thi Nguyen]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]


() Stefan Monnier <monnier@iro.umontreal.ca>
() Tue, 28 Feb 2017 00:37:35 -0500

   Hmm... I thought I'd been careful to avoid them.  Are these
   uses significant, or could we easily get rid of them and
   stick to posix sh?

My understanding is that ‘$(COMMAND)’ and function bodies that
don't begin in column 0 are bash-specific constructs.  Is that
not the case?

-- 
Thien-Thi Nguyen -----------------------------------------------
 (defun responsep (query)
   (pcase (context query)
     (`(technical ,ml) (correctp ml))
     ...))                              748E A0E8 1CB8 A748 9BFA
--------------------------------------- 6CE4 6703 2224 4C80 7502


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [elpa] master a179572 3/4: [admin] Specify bash in update-archive.sh shebang line.

[Stefan Monnier]

> My understanding is that ‘$(COMMAND)’ and function bodies that
> don't begin in column 0 are bash-specific constructs.  Is that
> not the case?

$(..) is definitely part of posix-sh and I can't remember the last
I heard mention of an sh that doesn't support it.

Not sure what you mean by "function bodies that don't begin in column
0", but that doesn't sound bash-specific either.


        Stefan

Re: [elpa] master a179572 3/4: [admin] Specify bash in update-archive.sh shebang line.

[Thien-Thi Nguyen]

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]


() Stefan Monnier <monnier@iro.umontreal.ca>
() Tue, 28 Feb 2017 02:22:58 -0500

   $(..) is definitely part of posix-sh and I can't remember the
   last I heard mention of an sh that doesn't support it.

   Not sure what you mean by "function bodies that don't begin
   in column 0", but that doesn't sound bash-specific either.

I mean stuff like:

 signal_error () {
 ...
 }

where the open-curly-brace is not at bol.  I've now perused
<http://mywiki.wooledge.org/Bashism> and run checkbashisms.
These concur w/ you.  So, i've reverted that change, bumped
the version, and pushed.  Thanks for pointing this out.

-- 
Thien-Thi Nguyen -----------------------------------------------
 (defun responsep (query)
   (pcase (context query)
     (`(technical ,ml) (correctp ml))
     ...))                              748E A0E8 1CB8 A748 9BFA
--------------------------------------- 6CE4 6703 2224 4C80 7502


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [elpa] master a179572 3/4: [admin] Specify bash in update-archive.sh shebang line.

[Andreas Schwab]

On Feb 28 2017, Thien-Thi Nguyen <ttn@gnu.org> wrote:

> I mean stuff like:
>
>  signal_error () {
>  ...
>  }

See
<http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_10>.
The linebreak before function_body represents _optional_ newlines.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [elpa] master a179572 3/4: [admin] Specify bash in update-archive.sh shebang line.

[Thien-Thi Nguyen]

[-- Attachment #1: Type: text/plain, Size: 784 bytes --]


() Andreas Schwab <schwab@linux-m68k.org>
() Tue, 28 Feb 2017 11:57:34 +0100

   See [link].  The linebreak before function_body represents
   _optional_ newlines.

Thanks for the link.  I see that the ‘linebreak’ production:

 linebreak        : newline_list
                  | /* empty */
                  ;

includes possibility of expanding to nothing, and wonder (idly)
if that was always the case.  Somehow i have the impression its
optionality is "new".

-- 
Thien-Thi Nguyen -----------------------------------------------
 (defun responsep (query)
   (pcase (context query)
     (`(technical ,ml) (correctp ml))
     ...))                              748E A0E8 1CB8 A748 9BFA
--------------------------------------- 6CE4 6703 2224 4C80 7502


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [elpa] master a179572 3/4: [admin] Specify bash in update-archive.sh shebang line.

[Stefan Monnier]

> includes possibility of expanding to nothing, and wonder (idly)
> if that was always the case.  Somehow i have the impression its
> optionality is "new".

Funnily enough, I had no idea that it was legal to put a newline
in there ;-)


        Stefan