Re: master 06a7963: Remove unused vars in cl-extra.el and tramp.el.

Re: master 06a7963: Remove unused vars in cl-extra.el and tramp.el.

[Michael Albinus]

monnier@iro.umontreal.ca (Stefan Monnier) writes:

Hi Stefan,

I'm curious:

>     * lisp/net/tramp.el (tramp-dissect-file-name): Remove unused `match'.
>     (outline-regexp, ls-lisp-use-insert-directory-program): Declare.
>     (tramp-find-foreign-file-name-handler): Mark unused arg, remove unused `v`.

[...]

> +(defvar outline-regexp)
> +
>  
> +(defvar ls-lisp-use-insert-directory-program)
> +

Why is this needed? Both variables are used let-bound only.

Best regards, Michael.

Re: master 06a7963: Remove unused vars in cl-extra.el and tramp.el.

[Stefan Monnier]

>> +(defvar outline-regexp)
>> +(defvar ls-lisp-use-insert-directory-program)
> Why is this needed? Both variables are used let-bound only.

Because they rely on dynamic scoping.
I know that you haven't set `lexical-binding` in your files, so it's not
*needed*, but with those declarations tramp.el is compatible with
`lexical-binding` (to the best of my knowledge).


        Stefan "whose local Emacs uses lexical-binding everywhere, and
                otherwise compiles with byte-compile-force-lexical-warnings"

Re: master 06a7963: Remove unused vars in cl-extra.el and tramp.el.

[Michael Albinus]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Why is this needed? Both variables are used let-bound only.
>
> Because they rely on dynamic scoping.
> I know that you haven't set `lexical-binding` in your files, so it's not
> *needed*, but with those declarations tramp.el is compatible with
> `lexical-binding` (to the best of my knowledge).

Thanks for explanation.

>         Stefan "whose local Emacs uses lexical-binding everywhere, and
>                 otherwise compiles with byte-compile-force-lexical-warnings"

Tramp is still compatible with Emacs 23. Once this is given up, we might
move Tramp to lexical-binding.

Best regards, Michael.

Re: master 06a7963: Remove unused vars in cl-extra.el and tramp.el.

[Stefan Monnier]

> Tramp is still compatible with Emacs 23. Once this is given up, we might
> move Tramp to lexical-binding.

You can set the lexical-binding:t cookie ans still use the code in
Emacs-23, as long as you make sure you stay to the common subset
(mostly: don't use closures).


        Stefan

Re: master 06a7963: Remove unused vars in cl-extra.el and tramp.el.

[Michael Albinus]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> You can set the lexical-binding:t cookie ans still use the code in
> Emacs-23, as long as you make sure you stay to the common subset
> (mostly: don't use closures).

Done.

>         Stefan

Best regards, Michael.