From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 06a7963: Remove unused vars in cl-extra.el and tramp.el. Date: Sun, 19 Mar 2017 08:47:46 -0400 Message-ID: References: <20170319023228.20393.27906@vcs0.savannah.gnu.org> <20170319023229.CB62020DF8@vcs0.savannah.gnu.org> <871stt3co7.fsf@detlef> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489927736 966 195.159.176.226 (19 Mar 2017 12:48:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 19 Mar 2017 12:48:56 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 19 13:48:52 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpaGM-0007Wz-2E for ged-emacs-devel@m.gmane.org; Sun, 19 Mar 2017 13:48:46 +0100 Original-Received: from localhost ([::1]:56764 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpaGQ-0003OB-EM for ged-emacs-devel@m.gmane.org; Sun, 19 Mar 2017 08:48:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpaFo-0003O6-L8 for emacs-devel@gnu.org; Sun, 19 Mar 2017 08:48:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpaFk-0007jq-Nw for emacs-devel@gnu.org; Sun, 19 Mar 2017 08:48:12 -0400 Original-Received: from [195.159.176.226] (port=55671 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cpaFk-0007ic-HB for emacs-devel@gnu.org; Sun, 19 Mar 2017 08:48:08 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cpaFP-0001xF-1t for emacs-devel@gnu.org; Sun, 19 Mar 2017 13:47:47 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 12 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:NJ1vMth6ZrW5I42zlLntoPnxT5w= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213150 Archived-At: >> +(defvar outline-regexp) >> +(defvar ls-lisp-use-insert-directory-program) > Why is this needed? Both variables are used let-bound only. Because they rely on dynamic scoping. I know that you haven't set `lexical-binding` in your files, so it's not *needed*, but with those declarations tramp.el is compatible with `lexical-binding` (to the best of my knowledge). Stefan "whose local Emacs uses lexical-binding everywhere, and otherwise compiles with byte-compile-force-lexical-warnings"