From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#29165: 26.0.90; can't use some code byte-compiled under emacs 24 Date: Wed, 13 Dec 2017 18:39:52 -0500 Message-ID: References: <6eh8u7x5be.fsf@just-testing.permabit.com> <87375r7f0g.fsf@users.sourceforge.net> <9f1e7a1f-bfc0-43a4-9acb-cf69b85587be@default> <5C8038D7-FF85-4C42-A728-F3F85CDAC85C@permabit.com> <87efpb46sp.fsf@linux-m68k.org> <3EB0E53F-4B99-44C2-9F2E-1125A33E408B@permabit.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1513208479 26556 195.159.176.226 (13 Dec 2017 23:41:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 13 Dec 2017 23:41:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Ken Raeburn , 29165@debbugs.gnu.org, Philipp Stephani , Andreas Schwab To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 14 00:41:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePGeH-0006TO-N9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Dec 2017 00:41:13 +0100 Original-Received: from localhost ([::1]:38334 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePGeL-0003Si-QB for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Dec 2017 18:41:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePGeB-0003QV-10 for bug-gnu-emacs@gnu.org; Wed, 13 Dec 2017 18:41:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePGe7-0000s2-0Q for bug-gnu-emacs@gnu.org; Wed, 13 Dec 2017 18:41:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52308) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ePGe6-0000rs-Sg for bug-gnu-emacs@gnu.org; Wed, 13 Dec 2017 18:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ePGe5-0005ZM-J1 for bug-gnu-emacs@gnu.org; Wed, 13 Dec 2017 18:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Dec 2017 23:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29165 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 29165-submit@debbugs.gnu.org id=B29165.151320840321322 (code B ref 29165); Wed, 13 Dec 2017 23:41:01 +0000 Original-Received: (at 29165) by debbugs.gnu.org; 13 Dec 2017 23:40:03 +0000 Original-Received: from localhost ([127.0.0.1]:60989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePGd8-0005Xe-8z for submit@debbugs.gnu.org; Wed, 13 Dec 2017 18:40:02 -0500 Original-Received: from pmta11.teksavvy.com ([76.10.157.34]:56750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePGd5-0005XH-Ta for 29165@debbugs.gnu.org; Wed, 13 Dec 2017 18:40:00 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2HsAgDLuTFa/zyu+M5dGQEBAQEBAQEBAQEBAQcBAQEBAYM+RoEUg15LixWOEwGBfBQgAZhxCoU1BAIChRJEFAEBAQEBAQEBAQNoKIUlAQQBIzMjBQsLDgwCGA4CAhQYDSSKMwipLoInimABAQgCASWBD4JRiHWFHYMVgmMFimKIRl6PGaEph2aWVhCBOzYjgU4yGggwgmSEcyOKYwEBAQ X-IPAS-Result: A2HsAgDLuTFa/zyu+M5dGQEBAQEBAQEBAQEBAQcBAQEBAYM+RoEUg15LixWOEwGBfBQgAZhxCoU1BAIChRJEFAEBAQEBAQEBAQNoKIUlAQQBIzMjBQsLDgwCGA4CAhQYDSSKMwipLoInimABAQgCASWBD4JRiHWFHYMVgmMFimKIRl6PGaEph2aWVhCBOzYjgU4yGggwgmSEcyOKYwEBAQ X-IronPort-AV: E=Sophos;i="5.45,398,1508817600"; d="scan'208";a="14286067" Original-Received: from 206-248-174-60.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([206.248.174.60]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2017 18:39:53 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 94866AE0DF; Wed, 13 Dec 2017 18:39:52 -0500 (EST) In-Reply-To: (Noam Postavsky's message of "Mon, 13 Nov 2017 15:05:09 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141049 Archived-At: >> (And if we=E2=80=99re going to make that sort of thing an error, we shou= ld >> probably check whether empty &key or &aux variable lists are similarly >> rejected. I haven=E2=80=99t looked.) I recently installed a patch to fix/improve the behavior of &aux with no keyword variable (I bumped into it while working on some Elisp package, tho I can't remember which right now). I think it's usually worth the small extra effort to support &optional not followed by any var (as well as &aux not followed by any var) since it sometimes comes in handy. But not if it costs extra at run-time. > Updated patch which handles &aux as well. I also tested a bootstrap > (doing this I found the previous patch messed up some positive cases). To the extent that &aux is only handled by macro-expansion, accepting an empty &aux never costs anything at run-time, so I think rejecting it is a disservice to our users. Stefan