From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums Date: Fri, 26 Oct 2018 10:17:33 -0400 Message-ID: References: <83bm7hozav.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1540563919 32268 195.159.176.226 (26 Oct 2018 14:25:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 26 Oct 2018 14:25:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 26 16:25:15 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gG335-0008Io-02 for ged-emacs-devel@m.gmane.org; Fri, 26 Oct 2018 16:25:15 +0200 Original-Received: from localhost ([::1]:60385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG35B-0002t2-F8 for ged-emacs-devel@m.gmane.org; Fri, 26 Oct 2018 10:27:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG2vk-00037p-NN for emacs-devel@gnu.org; Fri, 26 Oct 2018 10:17:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gG2vf-000738-PZ for emacs-devel@gnu.org; Fri, 26 Oct 2018 10:17:40 -0400 Original-Received: from alt42.smtp-out.videotron.ca ([23.233.128.29]:45339) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gG2vf-00072b-I4 for emacs-devel@gnu.org; Fri, 26 Oct 2018 10:17:35 -0400 Original-Received: from fmsmemgm.homelinux.net ([23.233.195.134]) by Videotron with SMTP id G2vdggacQM6QEG2veg2IjK; Fri, 26 Oct 2018 10:17:34 -0400 X-Authority-Analysis: v=2.3 cv=bq5i+nSi c=1 sm=1 tr=0 a=xXJ578j8WyTliCxld3/pTA==:117 a=xXJ578j8WyTliCxld3/pTA==:17 a=smKx5t2vBNcA:10 a=CCMdXstAfmCBEGPsMV0A:9 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id A449AAE31A; Fri, 26 Oct 2018 10:17:33 -0400 (EDT) In-Reply-To: <83bm7hozav.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Oct 2018 12:03:04 +0300") X-CMAE-Envelope: MS4wfFZoQaRUukHHKciQL0ipctMy8pvTZllpafrtpriJrhkS8C36dU9pKBFxE60D5dpww0+s7j999f65zWOiEwGWjzCqBR7rAgHww3JhdOUak48w12/YUWfr kgUbP2rV9li+38OFZGryB/NaX05dgsLhlFi8o6AM5yw6Cw5Tm89O6XC106WtmuBDDivb0bi5SUVXuXBcm+NslllYHrICQpICwc4rFdSIn2cdYale3wSmv6dR evCq9p6gnqlguVVyjZfyNQ== X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 23.233.128.29 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230705 Archived-At: > Stefan, this change needs a suitable change in the docs (both the doc > string and the ELisp manual): they still claim integers are compared > using 'equal', which AFAIU is now inaccurate. AFAIK using `eql` gives the same result as comparing with `equal`: It's just an internal optimization that is transparent to the user. So, just like we did not document the fact that integers (and symbols) where actually compared with `eq`, there's no need to document that they are now compared with `eql`: the intended semantics is to give the same result as when comparing with `equal` so that's what we document. The patch simply fixes the (unlikely but possible now) case where the pattern is an integer that's not a fixnum. Stefan