From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums
Date: Fri, 26 Oct 2018 10:17:33 -0400 [thread overview]
Message-ID: <jwvo9bgiypj.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <83bm7hozav.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Oct 2018 12:03:04 +0300")
> Stefan, this change needs a suitable change in the docs (both the doc
> string and the ELisp manual): they still claim integers are compared
> using 'equal', which AFAIU is now inaccurate.
AFAIK using `eql` gives the same result as comparing with `equal`:
It's just an internal optimization that is transparent to the user.
So, just like we did not document the fact that integers (and symbols)
where actually compared with `eq`, there's no need to document that they
are now compared with `eql`: the intended semantics is to give the same
result as when comparing with `equal` so that's what we document.
The patch simply fixes the (unlikely but possible now) case where the
pattern is an integer that's not a fixnum.
Stefan
next prev parent reply other threads:[~2018-10-26 14:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 9:03 [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums Eli Zaretskii
2018-10-26 14:17 ` Stefan Monnier [this message]
2018-10-26 15:02 ` Eli Zaretskii
2018-10-26 16:04 ` Stefan Monnier
2018-10-26 17:33 ` Eli Zaretskii
2018-10-26 18:23 ` Stefan Monnier
2018-10-26 19:00 ` Paul Eggert
2018-10-26 19:37 ` Stefan Monnier
2018-10-26 19:03 ` Eli Zaretskii
2018-10-26 19:37 ` Stefan Monnier
2018-10-27 12:15 ` Andy Moreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvo9bgiypj.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.