From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: TRAMP VC optimization: also breaks process filters -_- Date: Tue, 07 May 2019 11:42:24 -0400 Message-ID: References: <87lfzi1e4l.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="222403"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Daniel Pittman , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 07 17:43:22 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hO2FW-000vkL-Qx for ged-emacs-devel@m.gmane.org; Tue, 07 May 2019 17:43:22 +0200 Original-Received: from localhost ([127.0.0.1]:48870 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO2FV-0001YM-QR for ged-emacs-devel@m.gmane.org; Tue, 07 May 2019 11:43:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO2Ei-0001W6-Tc for emacs-devel@gnu.org; Tue, 07 May 2019 11:42:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hO2Ei-0002mI-4M for emacs-devel@gnu.org; Tue, 07 May 2019 11:42:32 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:59884) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO2Eh-0002m0-Vw for emacs-devel@gnu.org; Tue, 07 May 2019 11:42:32 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x47FgPW9010496; Tue, 7 May 2019 11:42:25 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 71C3866184; Tue, 7 May 2019 11:42:24 -0400 (EDT) In-Reply-To: <87lfzi1e4l.fsf@gmx.de> (Michael Albinus's message of "Tue, 07 May 2019 17:24:42 +0200") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6541=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6541> : inlines <7074> : streams <1820844> : uri <2841607> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236236 Archived-At: > Yes, the analysis is correct. However, we don't need to check this for > every Tramp invocation. Indeed, when the first arg of expand-file-name is absolute the second arg shouldn't matter. > Daniel's reports have been covered always > vc-registered. And indeed, the related `tramp-vc-file-name-handler' > seems to expect always a Tramp file name, which is not true for filters > and sentinels which run for non-Tramp processes. I don't understand what filers and sentinels have to do with it. > Daniel, does the appended patch fixes the issue for you? The patch looks good to me, at least, Stefan