From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Tue, 21 Jan 2020 11:32:18 -0500 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <7293f6ca-b11d-3d2a-ad71-831135434e75@yandex.ru> <780526337.114357.1578556168662@office.mailbox.org> <944631362.128066.1578605073103@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="32875"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 38992@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , waah@yellowfrog.io To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 21 17:34:25 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1itwTw-0008LP-SJ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jan 2020 17:34:24 +0100 Original-Received: from localhost ([::1]:57838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itwTv-00029w-Lf for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jan 2020 11:34:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37798) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itwSf-00014s-KX for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2020 11:33:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itwSc-0006Ty-1d for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2020 11:33:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42343) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1itwSb-0006Ti-PL for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2020 11:33:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1itwSb-0006Da-ME for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2020 11:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jan 2020 16:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.157962436623856 (code B ref 38992); Tue, 21 Jan 2020 16:33:01 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 21 Jan 2020 16:32:46 +0000 Original-Received: from localhost ([127.0.0.1]:48310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itwSL-0006Ch-J4 for submit@debbugs.gnu.org; Tue, 21 Jan 2020 11:32:46 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itwSG-0006CQ-Mp for 38992@debbugs.gnu.org; Tue, 21 Jan 2020 11:32:44 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DF812100B5E; Tue, 21 Jan 2020 11:32:34 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1158C100865; Tue, 21 Jan 2020 11:32:33 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1579624353; bh=kLnhwlHVuEtH9pMzOVGi1Qfc+gHBcs7C3zw7mTNRb7Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=A1ju2qPv+eGosONfNPrFVKTwwUTFxK69wfPe7Na6XEsKpgjdZXekJAtF1zJQ1O336 C6b+acbeg6jLQayniMMJl2ygLzWpWQiNGPCt4jEydNelZt947AkPMWyUpPcVpIiMrH oesL4vY+Jj6G4/tR5w6k1/9g9WTRSICYAy5XhPPzNpvxjP6PD9QmEYC6l51XXBCojW hxnFWyDQo7wRICiZNT8fueSxlB0tJ5bijnjvQf+cY+B5sLruOakA3oRo9vbmg2sRWh cWz7I4nK3AvC2OXjHF3gjHei3p/PnKCcEMbgBGF2Ms95GF5Mrrdx+Umg+tJxtSxK0l Zg4z2j8X5PegQ== Original-Received: from pastel (unknown [45.72.156.100]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9F49D1203B5; Tue, 21 Jan 2020 11:32:32 -0500 (EST) In-Reply-To: (Dmitry Gutov's message of "Tue, 21 Jan 2020 02:56:12 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175005 Archived-At: >> If `required` was nil (as is the case in `grep-read-files` which >> I believe is the relevant function here), then when `test-completion` >> fails, we should probably just call `exit-minibuffer` (rather than tell >> the user that they should do that). > > Ido added an extra prompt in situations like this, I think. What you're > saying was my first suggestion, but it would require a more invasive change. I haven't thought about what the code would look like, admittedly. Not sure why it would be particularly invasive, tho. > And icomplete-force-complete-and-exit, as implemented, calls > minibuffer-force-complete-and-exit which doesn't seem to care (or know?) > that REQUIRED was nil. Good point: `minibuffer-force-complete-and-exit` probably needs to be changed accordingly (i.e. to just `exit-minibuffer` when `required` was nil). > BTW, I now see that my patch changes a function belonging to icomplete, > whileas the intention was only to fix fido-mode's behavior. Do you think > the change fits icomplete-mode as well? I haven't kept track of icomplete-mode in enough detail to be sure, but I guess so. > Um, not sure I understand. The problem here is that typing 'all' > (unless it matches some of the local files names) or '*.el' and typing > RET doesn't work. I thought in the reported case, the user just selected the default (which happened to be a glob pattern). In any case I was just pointing out that adding the default to the head of the "completion candidates" increases the cases where the current problem shows up. Stefan