From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Raffael Stocker <r.stocker@mnet-mail.de>
Cc: emacs-devel@gnu.org
Subject: Re: [ELPA] New package: scanner
Date: Fri, 10 Apr 2020 16:43:10 -0400 [thread overview]
Message-ID: <jwvo8rzulb0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87y2r3qfiv.fsf@mnet-mail.de> (Raffael Stocker's message of "Fri, 10 Apr 2020 21:58:32 +0200")
>> I'm also wondering why you need all those `:key-sequence nil` in the menu.
>> Maybe it reflects a bug in our code?
> The Elisp doc says in (info "(elisp) Extended Menu Items"):
> ‘:key-sequence nil’
> This property indicates that there is normally no key binding which
> is equivalent to this menu item. Using this property saves time in
> preparing the menu for display, because Emacs does not need to
> search the keymaps for a keyboard equivalent for this menu item.
AFAIK we never bother with this optimization. Finding the key-sequence
is supposed to be very cheap (basically a hash-table lookup) because we
pre-compute a "reverse table" from commands to key-bindings.
[ This pre-computation is not that cheap but we the above keyword
argument doesn't prevent its computation. ]
> I just thought this is how it's done.
I guess we should adjust the doc, thanks.
Stefan
next prev parent reply other threads:[~2020-04-10 20:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 12:02 [ELPA] New package: scanner Raffael Stocker
2020-04-10 18:13 ` Stefan Monnier
2020-04-10 19:58 ` Raffael Stocker
2020-04-10 20:20 ` Raffael Stocker
2020-04-10 20:44 ` Stefan Monnier
2020-04-10 20:43 ` Stefan Monnier [this message]
2020-04-10 21:17 ` Raffael Stocker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvo8rzulb0.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=r.stocker@mnet-mail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.