From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Akira Kyle <ak@akirakyle.com>, emacs-devel@gnu.org
Subject: Re: gui_insert_glyphs in xdisp.c
Date: Thu, 15 Oct 2020 10:05:34 -0400 [thread overview]
Message-ID: <jwvo8l3y49c.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83tuuvy5kz.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 15 Oct 2020 16:35:56 +0300")
>> > The calls to this function were removed from the GUI display code
>> > when we deleted the "direct output for insert" redisplay
>> > optimization.
>> Thanks! Then I assume this was kept around in case someone in the
>> future wanted to utilize that part of the redisplay_interface?
> Maybe. Or maybe we simply didn't pay attention that there are no
> callers of this functions anymore.
As the guy who removed those optimizations, I must admit that I didn't
realize it made those functions dead code. So it definitely wasn't done
"in case someone in the future wanted to utilize that part of the
redisplay_interface" ;-)
Stefan
prev parent reply other threads:[~2020-10-15 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 0:43 gui_insert_glyphs in xdisp.c Akira Kyle
2020-10-14 14:01 ` Eli Zaretskii
2020-10-14 19:15 ` Akira Kyle
2020-10-15 13:35 ` Eli Zaretskii
2020-10-15 14:05 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvo8l3y49c.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=ak@akirakyle.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.