From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Merging native-comp and pgtk Date: Fri, 12 Feb 2021 18:04:10 -0500 Message-ID: References: <07D5E64D-DAD0-45B3-B272-627A73D7CBAE@gmail.com> <87sg6alweo.fsf@gnus.org> <87pn1erewq.fsf@gmail.com> <87wnvlecrw.fsf@gnus.org> <83sg69o3av.fsf@gnu.org> <87mtwhctte.fsf@gnus.org> <459A0475-E3E7-4159-82DF-93809CCF1E24@gmail.com> <87eehng52n.fsf@gnus.org> <87mtwbye5b.fsf@gmail.com> <87czx7ycva.fsf@tcd.ie> <87eehmyalr.fsf@gmail.com> <877dneoewi.fsf@tcd.ie> <875z2yy6z7.fsf@gmail.com> <878s7twq2t.fsf@gmail.com> <84adc238-c424-bb6b-da28-c4232172da5b@gmx.at> <83wnvddtgh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37575"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 13 00:06:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lAhVy-0009fn-PY for ged-emacs-devel@m.gmane-mx.org; Sat, 13 Feb 2021 00:06:18 +0100 Original-Received: from localhost ([::1]:50778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAhVx-0004eX-Eh for ged-emacs-devel@m.gmane-mx.org; Fri, 12 Feb 2021 18:06:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAhU1-00047g-FB for emacs-devel@gnu.org; Fri, 12 Feb 2021 18:04:17 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27136) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAhTz-0006uE-58; Fri, 12 Feb 2021 18:04:16 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A8E1944109B; Fri, 12 Feb 2021 18:04:13 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 26F1D441080; Fri, 12 Feb 2021 18:04:12 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1613171052; bh=STMdnma2RPycbK6hzFppbB5QoIWhlYLc3Qk8+u9KaSU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CZzbIrNE8umW84l00C0MAOF52iEgbbCK6FQPcE0w1diyFuHqOEwHSrRD8Lvje3uRQ 0gdREf9S0C5wBWYay27v/SCMnbejPq36/1tWFmpYr6vYr4bwnEdbxef7ZWCJfcmlQv LVzZ2JiQJDbdi4u72nAQ/hRd0ShQras61B3dEFKdsktE9wEL8rDXq3kzoyXV9hFuGq kJe5zshpKhfJV1kFU8zoL3bnynAWTgH0CN2wULOmF7E5q1JuQ6I2LOSlnjyFrpJfUi UpTKLXK5JE8Qr1JODy2YOC8ARxKi/tLaCKF7+6VmfbzAWtpz9A0JgyUUi0hKta7mln RZ1mZSzwzDNOQ== Original-Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D92FE120327; Fri, 12 Feb 2021 18:04:11 -0500 (EST) In-Reply-To: <83wnvddtgh.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Feb 2021 20:36:14 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264565 Archived-At: >> Where are we w.r.t merging those two branches into `master`? >> IIUC the plan is to include those features as "experimental" in >> Emacs-28.1, right? If so, I think it's becoming urgent that we merge >> them into `master`. > I don't thin it's ready yet, see my other message. By "it" you mean both features? I've seen some reference to the pgtk branch in another message but that seemed to be a minor issue when using pgtk. So now I'm wondering: what do you think should be the criteria for inclusion into `master`? As written above, I thought the plan was to include those as experimental features for Emacs-28.1, so I thought the criteria were going to be something like: - Code is clean enough: doesn't risk introducing regressions into the rest of the code. - It's very likely that the feature will reach maturity (i.e. lose the "experimental" label) in some not too distant future. - It's already usable enough that most people who're looking forward to this feature will be fairly satisfied if they try it (it might still have some rough edges, but by and large it works). > (And why is it urgent? Emacs 27.2 is not out yet, and Emacs 28 is > supposed to have native-comp included. So we still have quite a long > way to go.) Leaving a feature waiting on a branch for extended period of time imposes a lot of extra work to keep it up to date (and it can very discouraging to have to do that if there's no clear set of "things missing"). Stefan