From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/corfu 6572247 3/4: Bind [tab] and [return] Date: Sat, 26 Jun 2021 10:02:31 -0400 Message-ID: References: <20210626095705.11804.96621@vcs0.savannah.gnu.org> <20210626095707.B514720D0A@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31390"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Daniel Mendler To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 26 16:03:52 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lx8uV-00081S-RC for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Jun 2021 16:03:51 +0200 Original-Received: from localhost ([::1]:36414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lx8uU-0002VZ-SQ for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Jun 2021 10:03:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lx8tO-00014J-Lp for emacs-devel@gnu.org; Sat, 26 Jun 2021 10:02:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:51971) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lx8tH-0000YA-53 for emacs-devel@gnu.org; Sat, 26 Jun 2021 10:02:41 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C103A808AB; Sat, 26 Jun 2021 10:02:33 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A2891801F2; Sat, 26 Jun 2021 10:02:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1624716152; bh=gTX1svBm+aqaOosJ5vztaswN4+k++Ls6O/PAZ50/zgs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bE/ZH8chKplTYUeGxCEcDdZFDR21X1diCrCxk07sqCSpTdWMwRgBUB2dlxRDF379u lAYuG+589ETfsjzj8w4Q271eLtZQHXXKaM5RStCIFHil0bR6dMqKLyTZ7I2eqJdNVa R5ps/OJ3/CUJA7GBbAV3Bd4ZOoO/4//3cBXFj1EOmN/NjLEbkYQwtk1ffz6yBc1pD2 h8F1t2GtRBKpJD4AK5G9XE1g8a27EHsT74boRgyrth3GTsnufshvuYnfP9/qsFcwPJ bDY3yjpx+d883XM6vYXNidBltK1ExBv5zEyAwfnF8E+lpCcY7tqj2PywaQF5y7e39Y 9BWaUDB83LWVA== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6923F120473; Sat, 26 Jun 2021 10:02:32 -0400 (EDT) In-Reply-To: <20210626095707.B514720D0A@vcs0.savannah.gnu.org> (ELPA Syncer's message of "Sat, 26 Jun 2021 05:57:07 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271033 Archived-At: > + (define-key map [tab] #'corfu-complete) Please avoid binding `tab`: the `tab` event (only generated under GUIs) is supposed to be remapped to the TAB char-event (aka `C-i`) and this is what you should bind to if you want your binding to work both under ttys and GUIs. More importantly, if you bind to `tab` than this binding will take precedence over all other bindings to TAB, even those in keymaps that have higher precedence. The same holds for `return` vs RET, and `escape` vs ESC. Stefan