From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Developing a PHP package Date: Sat, 04 Sep 2021 12:51:04 -0400 Message-ID: References: <87pmto47r1.fsf@hugot.nl> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18273"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Hugo Thunnissen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 04 18:52:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMYtm-0004VF-Kf for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Sep 2021 18:52:10 +0200 Original-Received: from localhost ([::1]:56218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMYtl-00059b-7o for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Sep 2021 12:52:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMYsq-0004ST-V0 for emacs-devel@gnu.org; Sat, 04 Sep 2021 12:51:12 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMYsm-00040c-Mq for emacs-devel@gnu.org; Sat, 04 Sep 2021 12:51:11 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4950E80768; Sat, 4 Sep 2021 12:51:09 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9777280677; Sat, 4 Sep 2021 12:51:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1630774267; bh=ghcckoKw5PGX87KXLijdHqPIfSkLXAWvKQ2uWavNoyQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=BgUa0Pu3uMNKocqldENRYwRD5Kk9BkblfVX86AlNumq0KzS0g+a3B1Uu7QmZRD8KM 5ycTd1Qc9a/DlQc2cyVGF8NNsJEChFa2UnGRqdogj0KaFQl5j5t3YhnUQ774nMxVjq FydoiakNLjtdAgj/kxg4XIDnKG+yBWm0OVQ1doLYJUx2LZQuVm5lVyxL4T1T2GUUQq WoJBQkxiCUsFFTkYGS+D0jVdl4/vLnqYhBW8PIIt0m4vvlqGzmsejjk7yWjymW5CPV yALZBv4bQfgew85HivRa02QApw+bcGK9K2cXmgV+/BV0wdanzIqgOZVQTMRrgaAtik u36Db0s+TqHKw== Original-Received: from milanesa (unknown [104.247.244.135]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1282C120337; Sat, 4 Sep 2021 12:51:05 -0400 (EDT) In-Reply-To: <87pmto47r1.fsf@hugot.nl> (Hugo Thunnissen's message of "Sat, 04 Sep 2021 16:37:22 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273934 Archived-At: > the emacs core would have my preference. Is there interest in having > such a package in the emacs core? I'll let Emacs maintainers decide whether they want it in the core, but I'd be happy to add it to GNU ELPA. In both cases we'd first need you to sign some copyright paperwork anyway. If you're OK with that, please fill the form after my sig and send it to the FSF as instructed so they can send you the appropriate paperwork to sign. > - I have read that there is work being done on incorporating lib > tree-sitter in emacs, would tree-sitter make a package like mine > obsolete? Could be, but in my experience, there's often room for several competing solutions anyway. > - The parser is currently only used for completion, but could > theoretically also be used (with some modifications) to do syntax > highlighting and indentation, making for somewhat of an alternative to > PHP-mode in the future. Would there be interest in something like > that? Yes. Better would be for it to be a *complement* rather than an alternative, so that improvements don't need to be duplicated in the two packages. > - The package has a dependency on a bash script that uses some GNU > coreutils (find, grep) and diff from GNU diffutils. The script is used > to find files containing definitions of PHP classes and namespaces, > but not for any of code parsing. What is the policy for emacs packages > having dependencies on external programs like that? Emacs already has such dependencies (e.g. `M-x diff`, `M-x grep`, ...), so that's not a problem. Some of your users may be affected (typically under Windows), but that's secondary (it's only a matter of "quality" than policy). Do you have a Git repository for your code somewhere? Stefan Please email the following information to assign@gnu.org, and we will send you the assignment form for your past and future changes. Please use your full legal name (in ASCII characters) as the subject line of the message. ---------------------------------------------------------------------- REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES [What is the name of the program or package you're contributing to?] Emacs [Did you copy any files or text written by someone else in these changes? Even if that material is free software, we need to know about it.] [Do you have an employer who might have a basis to claim to own your changes? Do you attend a school which might make such a claim?] [For the copyright registration, what country are you a citizen of?] [What year were you born?] [Please write your email address here.] [Please write your postal address here.] [Which files have you changed so far, and which new files have you written so far?]