From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master b89ae23636: Implement crossing event generation between windows for xwidgets on X Date: Thu, 27 Jan 2022 09:14:08 -0500 Message-ID: References: <164326325703.8534.15638551587582614326@vcs2.savannah.gnu.org> <20220127060101.0FAA9C41E57@vcs2.savannah.gnu.org> <87zgnhk4hg.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6941"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 27 15:24:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nD5ho-0001cF-36 for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Jan 2022 15:24:56 +0100 Original-Received: from localhost ([::1]:50400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nD5hn-0000Sm-04 for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Jan 2022 09:24:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nD5XZ-0007fl-Ri for emacs-devel@gnu.org; Thu, 27 Jan 2022 09:14:21 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52717) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nD5XX-00027V-Bj for emacs-devel@gnu.org; Thu, 27 Jan 2022 09:14:21 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C6E16442969; Thu, 27 Jan 2022 09:14:16 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7060D442967; Thu, 27 Jan 2022 09:14:15 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1643292855; bh=GTyAvm2JhctrfQ7PkPRQjses/diMJksaPlFV6+v0aLg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=F/70enR7XAlV1M5+G9FU9GBhSsalvY/6Tgu6ARQQCKfWfyF9PtYVof7PHP4XX4g1G zDDWTTVZ4b5p9Es+gLLXnP0QvY96EgMayo7egZ1rIJq/m0YQgpI36PcKOgnJB0MdSS +2iFDBAsoIRYJJ38Pp2hQ8EbcRgdwXKNAleBco5nmn9QP+15An7UyHY5fL57pefz0u 9UOs4cGv4Q2TZRi88OW1fn3y1BLte6yTRPvCezm59FmryTSF9eApvFmUdn2nWgr5NM GfNaQQDMLuuqHS+BemUFgkkEmel7G9I1Jq7Pzs/BSmpjP/ELaDorzzS6ZaP7G79WZj mtLR5d5H7ZCWQ== Original-Received: from ceviche (76-10-138-212.dsl.teksavvy.com [76.10.138.212]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2F5601208BE; Thu, 27 Jan 2022 09:14:15 -0500 (EST) In-Reply-To: <87zgnhk4hg.fsf@yahoo.com> (Po Lu's message of "Thu, 27 Jan 2022 15:44:11 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285491 Archived-At: >> I think this deserves some comments explaining what is "crossing" here. >> Maybe a URL to some docs? > XW_CROSSING_LEFT and XW_CROSSING_ENTERED mean the same as they do on X, > so those two should be obvious to anyone with reason to look at the > xwidgets code. OK. I'm obviously not well versed in GUI code, so maybe I'm a bad judge. But I have looked (and touched) at some of Emacs's GUI code (e.g. had a hack to split key presses events into `a` and `up-a`) so I'm at least remotely familiar with X11 events yet I've never heard of "crossings" and have hence no clue what your code is about. > But if you still insist, I have no objections to installing a comment > explaining things there. I don't insist, I'll let you judge. I'm just pointing out that your code looked completely mysterious to me. Stefan