From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50245: 28.0.50; Instrumenting a function does not show "Edebug:" in the echo area Date: Thu, 25 Aug 2022 08:47:54 -0400 Message-ID: References: <87r1ecdobe.fsf@gnus.org> <87o7wc2spo.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25547"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 50245@debbugs.gnu.org, Lars Ingebrigtsen To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 25 14:50:41 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRCJl-0006T6-L0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Aug 2022 14:50:41 +0200 Original-Received: from localhost ([::1]:40232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRCJk-000814-Nm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Aug 2022 08:50:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRCIC-0007IE-Pp for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2022 08:49:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59578) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRCIA-0002GD-GY for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2022 08:49:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRCIA-0006w6-AK for bug-gnu-emacs@gnu.org; Thu, 25 Aug 2022 08:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Aug 2022 12:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50245 X-GNU-PR-Package: emacs Original-Received: via spool by 50245-submit@debbugs.gnu.org id=B50245.166143168526523 (code B ref 50245); Thu, 25 Aug 2022 12:49:02 +0000 Original-Received: (at 50245) by debbugs.gnu.org; 25 Aug 2022 12:48:05 +0000 Original-Received: from localhost ([127.0.0.1]:49324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRCHF-0006ti-9y for submit@debbugs.gnu.org; Thu, 25 Aug 2022 08:48:05 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRCHC-0006sa-Pe for 50245@debbugs.gnu.org; Thu, 25 Aug 2022 08:48:03 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E8D3D441000; Thu, 25 Aug 2022 08:47:56 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 295A5440FFD; Thu, 25 Aug 2022 08:47:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1661431675; bh=GU0Mey4mfWyjLrgha4pggqJsiJwtVGBYN1t3h+huMgE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=UR/rW0qHJC3kNDtcqVyEhQy3hhHc+MvMYVo95thB0oGJ8/a9+NixgGDR8lW+WwcjL 4FfDZWyvhmTHM9PJLUNNYwIjHP7uNDOSoFO2of6V/vHwSs+DQUl89RB4qbNqY7ibzM wsE1WF/uscji5nVZF2TsNa5IwJ3OjTURXZtiLBy8LV9TLRWFi6+8Du8/FBtnnB6XGA PA7X4/t1omvOXzpWNfa3FZYKe9s2ZZrBoAEAoWnRlbJPpivh2cc0uknEZOadf+yoG1 7sWljv8adYqiB1fQ3TrXTtpiMMs3mWiqBw40N1Dy2ovkiGrDtPWMqITsGuUXgRFjv9 8/6hUtj3KmYkg== Original-Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 073BA1204EE; Thu, 25 Aug 2022 08:47:55 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Wed, 24 Aug 2022 22:06:53 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240703 Archived-At: >> Here's a new version of the patch, which addresses Stefan's feedback. > > Thanks. One question, tho: > >> @@ -1643,7 +1643,10 @@ elisp--eval-defun >> ;; FIXME: the print-length/level bindings should only be applied while >> ;; printing, not while evaluating. >> (defvar elisp--eval-defun-result) >> + ;; FIXME: This Edebug dependency is undesirable. See bug#50245 >> + (defvar edebug-all-defs) >> (let ((debug-on-error eval-expression-debug-on-error) >> + (edebugging edebug-all-defs) >> elisp--eval-defun-result) >> (save-excursion >> ;; Arrange for eval-region to "read" the (possibly) altered form. > > What makes us think that `edebug-all-defs` will always be defined when > we get here? Doesn't this code signal an error if called before > edebug.el is loaded (e.g. in the case of `emacs -Q` soon followed by > a plain `C-M-x`)? IOW, I'd remove the `defvar` and use (bound-and-true-p edebug-all-defs) instead. Stefan