From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "Daniel Martín" <mardani29@yahoo.es>
Cc: 50245@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#50245: 28.0.50; Instrumenting a function does not show "Edebug:" in the echo area
Date: Thu, 25 Aug 2022 08:47:54 -0400 [thread overview]
Message-ID: <jwvo7w84hjk.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwvh7215bdc.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 24 Aug 2022 22:06:53 -0400")
>> Here's a new version of the patch, which addresses Stefan's feedback.
>
> Thanks. One question, tho:
>
>> @@ -1643,7 +1643,10 @@ elisp--eval-defun
>> ;; FIXME: the print-length/level bindings should only be applied while
>> ;; printing, not while evaluating.
>> (defvar elisp--eval-defun-result)
>> + ;; FIXME: This Edebug dependency is undesirable. See bug#50245
>> + (defvar edebug-all-defs)
>> (let ((debug-on-error eval-expression-debug-on-error)
>> + (edebugging edebug-all-defs)
>> elisp--eval-defun-result)
>> (save-excursion
>> ;; Arrange for eval-region to "read" the (possibly) altered form.
>
> What makes us think that `edebug-all-defs` will always be defined when
> we get here? Doesn't this code signal an error if called before
> edebug.el is loaded (e.g. in the case of `emacs -Q` soon followed by
> a plain `C-M-x`)?
IOW, I'd remove the `defvar` and use (bound-and-true-p
edebug-all-defs) instead.
Stefan
prev parent reply other threads:[~2022-08-25 12:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m1wno5hxij.fsf.ref@yahoo.es>
2021-08-29 1:04 ` bug#50245: 28.0.50; Instrumenting a function does not show "Edebug:" in the echo area Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-29 19:48 ` Lars Ingebrigtsen
2021-10-02 13:06 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-02 15:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-22 15:39 ` Lars Ingebrigtsen
2022-08-24 22:32 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-25 2:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-25 12:38 ` Lars Ingebrigtsen
2022-08-25 13:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-25 12:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvo7w84hjk.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=50245@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mardani29@yahoo.es \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.