From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/auctex cb0a1e6be1 72/77: Improve function calls to retrieve key=vals in style hooks Date: Fri, 26 Aug 2022 16:28:50 -0400 Message-ID: References: <166154439039.10036.933483657788018296@vcs2.savannah.gnu.org> <20220826200639.2B668C00889@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18746"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Tassilo Horn To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 26 22:29:59 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRfxn-0004hx-ML for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Aug 2022 22:29:59 +0200 Original-Received: from localhost ([::1]:53978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRfxm-0007mu-JD for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Aug 2022 16:29:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRfwp-0006cI-UE for emacs-devel@gnu.org; Fri, 26 Aug 2022 16:29:00 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17428) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRfwn-0007RL-1I; Fri, 26 Aug 2022 16:28:58 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 07C7C4418E3; Fri, 26 Aug 2022 16:28:55 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7BB0C441244; Fri, 26 Aug 2022 16:28:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1661545733; bh=Mskn9sQSBY80cQpMXF98bBZzbOrAvmBMECyEISJdwG8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pYuSa1kGghva5kY17cptKiex0o8jau03qekn5qjkjWHtq2l4SsL46tbZAJ6VBZ8ja XjPnJht2Gi8zvtqHo9Cw5d8jyeFFcUGJF4y5dzX0yGdHMBSUB9BsrQ60yIiKk5ci0u oAF7cxYzAHWH+jwyWVi0PjugIiwNrUMo3ARCor208UDyJ0Fq6n/M0CudBpcnWdnGUf XoRArCUqJAASol8a8YzLe5oASHnzfvAJbZCBubinJe5WY7OKyVdtcYGIVu+fZWqNcK 4x5dCqiiIvdfsZQwx5tKOlZZBiVnSX1aNQ1wwxEKc8BWFIujD0zWOpjrXk9lMY6bK8 KcRz2zSR1qKLA== Original-Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 57C7312048F; Fri, 26 Aug 2022 16:28:53 -0400 (EDT) In-Reply-To: <20220826200639.2B668C00889@vcs2.savannah.gnu.org> (Tassilo Horn's message of "Fri, 26 Aug 2022 16:06:39 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294163 Archived-At: Tassilo Horn [2022-08-26 16:06:39] wrote: > Improve function calls to retrieve key=vals in style hooks > > * latex.el (TeX-read-key-val): Improve call of functions as > argument of `TeX-arg-key-val' inside style hooks. [...] > (fboundp (car key-val-alist))) > - (let ((head (car key-val-alist)) > - (tail (cdr key-val-alist))) > - (apply head tail))) > + (if (> (length key-val-alist) 1) > + (eval key-val-alist t) > + (funcall (car key-val-alist)))) > (t FWIW, replacing `apply` with `eval` is not an "Improve"ment in my book :-) It means now that `key-val-alist` contains code represented as data (i.e. code to which flymake, the compiler, the eager macroexpander, etc... don't have access) whereas it previously only contains values (which can't contain code that needs macroexpansion, for example). Stefan