From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Date: Fri, 14 Oct 2022 13:04:31 -0400 Message-ID: References: <87lepmusw5.fsf@posteo.net> <87pmexcn1h.fsf@gnus.org> <87edvd5bun.fsf@gmx.de> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36242"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Thierry Volpiatto , Lars Ingebrigtsen , 58446@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 14 19:05:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojO7h-0009Bj-DS for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Oct 2022 19:05:25 +0200 Original-Received: from localhost ([::1]:34022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojO7f-0005wd-Cg for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Oct 2022 13:05:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojO7K-0005wS-F9 for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 13:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39418) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojO7K-00039F-7A for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 13:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ojO7K-0001Kd-26 for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 13:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Oct 2022 17:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58446 X-GNU-PR-Package: emacs Original-Received: via spool by 58446-submit@debbugs.gnu.org id=B58446.16657670845085 (code B ref 58446); Fri, 14 Oct 2022 17:05:02 +0000 Original-Received: (at 58446) by debbugs.gnu.org; 14 Oct 2022 17:04:44 +0000 Original-Received: from localhost ([127.0.0.1]:38496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojO71-0001Jx-T0 for submit@debbugs.gnu.org; Fri, 14 Oct 2022 13:04:44 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojO6z-0001Jk-D7 for 58446@debbugs.gnu.org; Fri, 14 Oct 2022 13:04:42 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BFADD10012E; Fri, 14 Oct 2022 13:04:35 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 22D67100098; Fri, 14 Oct 2022 13:04:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1665767074; bh=rhBVn+ikBxzEUdmZbvy2TaM2rjxSLSNLFLjEiK+R2R4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Vo0CHso9n3Ls4zJcO8MHpK+ENqf1VpYuFDEDkZ+HGPp8kMeziM4k+10h3eBZNBtF4 p2gBhVWtCnbcSF0ejrNbqpyWFg9toOYabcgqrUbNVdfq98NtQQDbbU8unEguZF8ySc /uMeq8/CUegnvMsZbfYAKiJtHx/9RIxrV67UKOenz0nveqkZ/a+rLx3mIAnClPV/fO qIebrUz64zmECTF4bTw4XyrQgh610M9QpSwkH/UXuiCz5fCeHmRA4Y8NUAoc8SWcSC Lm2MC79DyeYRYC7z+1nwXi734mMYEArD7kVKecJ7+seuFXrd9ug9aqQpRo2WNxtT1y xRxrHUT3CW9cA== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EB9D0120F32; Fri, 14 Oct 2022 13:04:33 -0400 (EDT) In-Reply-To: <87edvd5bun.fsf@gmx.de> (Michael Albinus's message of "Wed, 12 Oct 2022 16:57:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245466 Archived-At: > (defsubst file-attribute-file-number (attributes) > "The inode and device numbers in ATTRIBUTES returned by `file-attributes'. > It can be used to determine whether two files are identical." > (nthcdr 10 attributes)) > > WDYT? Sounds good, except: - The name `file-attribute-file-number` doesn't sound right because it doesn't return a number. - I wouldn't use `defsubst` (so it can more easily be modified in the future, e.g. in case we add more fields to the attributes or use some other representation for attributes). - I would document it more abstractly, mentioning inode and device number only as *examples* of things it might contain. Stefan