From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Plug treesit.el into other emacs constructs Date: Wed, 14 Dec 2022 14:35:51 -0500 Message-ID: References: <87wn6whete.fsf@thornhill.no> <87r0x3gnv5.fsf@thornhill.no> <04BB786A-3ED1-4918-8583-17AA01A1E453@gmail.com> <4E3940CA-67A6-45B7-8785-4E60FDECCDFB@gmail.com> <4315EFC6-7AA8-4A48-845C-9CA8B88034D9@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8823"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Yuan Fu , emacs-devel@gnu.org, eliz@gnu.org To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 14 20:37:06 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5XYv-00026W-Sk for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Dec 2022 20:37:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5XY7-0001LA-Lw; Wed, 14 Dec 2022 14:36:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5XY0-0001KZ-Ba for emacs-devel@gnu.org; Wed, 14 Dec 2022 14:36:09 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5XXv-0005wy-Ng; Wed, 14 Dec 2022 14:36:06 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 86FF38067F; Wed, 14 Dec 2022 14:35:58 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A90968022B; Wed, 14 Dec 2022 14:35:52 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1671046552; bh=82E34DD5Y30FBBj+70I6K/bLhVX0QXHb3Kmy5/u8PkA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=phenVPVWUjqI3fuHeBvy/7/ZuJi72vp7L8M9zZF7xMhDB48ftmpHItVuqmztveWGt 8oWf3BTSBFOtd+BO5B0KjWZKTFSTvQkmnd14Y8ac6Xw9RK/HyDxiOqc9gGl9Qo1Tti qDhYypOQGHFs7I6mrQ/FeNK4kL5QoBlHOckXFSUjUSa7cl64Me6onk3sF3+zbjALXd zzM22nTMVmUZJMbm+dnI9RlzOBsiVgJhEzwatd6HLMIwaC6G5JXWoz5mX2bCu6nkaW y0eqWHzm+MUoMEsRuwkOMqPTn8VLQFviyx3BM0qi7uK8I2EzDy1cNyhiQRZSfAxnD3 BDJZzjUTiZ5DA== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 976A412019B; Wed, 14 Dec 2022 14:35:52 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Wed, 14 Dec 2022 14:25:19 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301408 Archived-At: >>>In this case, yes. But in other cases it will move at different levels >>>of the tree. E.g.: >>> >>> int x = f (b + 4, c * 7 - z * 2, d, e); >>> >>>It will sometimes move over the whole instruction, and other times over >>>just a single variable or over a whole argument or over just a "factor". >>>This depends on where point is when `forward/backward-sexp` is called. >> >> Yeah. I think this example shows what I find unintuitive. If point is right >> before the first comma, and we transpose-sexps, it could end up swapping >> 4 for c * 7 - z * 2, which would rarely make sense in this context. > > If so, that would be a bug in `transpose-sexp`, agreed. > I'm talking here about `forward/backward-sexp`. > The two are linked, but we shouldn't use one to justify a bug in the other. > > `Forward-sexp` from ^^^^^^^^^^^^ transpose-sexp Duh! Stefan