From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sat, 15 Jul 2023 12:01:50 -0400 Message-ID: References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <83r0p9b3om.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36158"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: yantar92@posteo.net, 64596@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 15 18:03:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKhjo-00096Y-HQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jul 2023 18:03:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKhjc-0004YI-8w; Sat, 15 Jul 2023 12:03:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKhjb-0004XW-1r for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 12:03:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKhja-00072h-Qh for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 12:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKhja-0004Jn-9d for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 12:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 16:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168943692416527 (code B ref 64596); Sat, 15 Jul 2023 16:03:02 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 15 Jul 2023 16:02:04 +0000 Original-Received: from localhost ([127.0.0.1]:45831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKhid-0004IU-SA for submit@debbugs.gnu.org; Sat, 15 Jul 2023 12:02:04 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:8038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKhiY-0004Hv-0G for 64596@debbugs.gnu.org; Sat, 15 Jul 2023 12:02:01 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 183121000CA; Sat, 15 Jul 2023 12:01:52 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 03531100098; Sat, 15 Jul 2023 12:01:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689436911; bh=bNOg1d1tkQaqHjqFWcOLdXDpl+ySuJVF8Vop1PNgBcs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=T4bCgZKSAfvPm5Owgbyra3Cvk5K01NizIkhKWQddL9GYR6NTct09+8ay7yKyM+LCX VCDwNE+xw7JFE9O+XE1mFsmVo1juqXDbvNDmMkBQ9EnzXqRc7RiJ3imVLU6Q9IIPF0 s6mdFYhFV1Btz/jOX3+yCGjZ14jlgUlt3WGRE9DDGZr+WfnD/mXgwMFmrasD8fa0hd VimXMYlDZTZVNSUFX/hclr3qlPBNBXuTtLlYd7uzPDOAFUm4RSWENkoVLc0bpnEbwH k4zqnjT8QYSf9C8Y8yBEqoHb+qmKp2cGOM4sdO5tJZwbSjAzks9ylsc8L3P/BrRHZ4 zVp4Ral3CdxBw== Original-Received: from pastel (unknown [108.175.230.17]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CC2A312019A; Sat, 15 Jul 2023 12:01:50 -0400 (EDT) In-Reply-To: <83r0p9b3om.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Jul 2023 18:22:01 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265223 Archived-At: > But what happens in reality is that the breaking changes are made, and > then the "guilty parties" disappear into thin air, or lose interest. > And we are left with a broken redisplay and an unfinished project. I didn't disappear into thin air, did I? Maybe I shouldn't take this personally, but my `redisplay-bit` changes are the only changes I'm aware of in this kind of vicinity, so I can't help but feel that this experience is an important point of reference for both of us. >> That's eactly what happened when I introduced the 3 `redisplay` bits >> above: it did introduce a few bugs, but overall it made the code >> more clear. > No, that's not "exactly" what happened. Some of the bugs popped up > much later, among other things. I agree that the added comments made > the situation better, but you know as well as I do that some of the > aspects of those variables are still somewhat mysterious: specifically > the meaning of windows_or_buffers_changed and update_mode_lines for > disabling optimizations and shortcuts. Which is exactly the focus of > the current discussion. Those aspects are not due to my changes. If they are mysterious it's because the remained mysterious, i.e. because I did not change them. [ Actually, I did change them a bit to help track them down: I changed those vars from booleans to integers where the integer is a "code" for the place where it has been "mysteriously set". And you can check `redisplay--all-windows-cause` and `redisplay--mode-lines-cause` to see how many times each of those "mysterious causes" has been used :-) ] This said, the meaning of those vars is clear, I think (they mean, that all the windows/modelines need to be updated). What still isn't clear at some places is the reason why they're set. >> > and guess who gets to work on fixing them. >> AFAIK, for the bugs introduced by those `redisplay` bit: I did, as >> it should. > Not all of them. Admittedly, sometimes it's difficult to know beforehand whether the bug may be due to those changes, so you may end up wasting your time before you can redirect the bug to the appropriate person, but this is another place where having that `internal--use-old-slow-redisplay` variable would help. Stefan