From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Adding refactoring capabilities to Emacs Date: Fri, 08 Sep 2023 11:42:07 -0400 Message-ID: References: <83fs4f36wi.fsf@gnu.org> <1b963d24-51b3-8128-ad14-e4af2c9f0c43@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6222"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , Eli Zaretskii , "Philip K." , emacs-devel@gnu.org To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 08 17:42:56 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeddI-0001N5-BE for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Sep 2023 17:42:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qedck-00053x-FY; Fri, 08 Sep 2023 11:42:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qedcj-0004z9-5d for emacs-devel@gnu.org; Fri, 08 Sep 2023 11:42:21 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qedcg-00044f-PN; Fri, 08 Sep 2023 11:42:20 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6D06D4432D8; Fri, 8 Sep 2023 11:42:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1694187729; bh=qS5vXX/WkiVBHvxiQwvhMGmgvWqRd6m9L5zco5V0Sw8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XEVmPI8pjDuvuXG4aV9TSSMd/vRVLhhMoJdBZ1QjK514C0sScIxW2uE5RLvpLh5pT Bkw/21xxxdN5IqT7xmMXKAgZySP7CNcNCeFqd6AFqzQkAMShU+GsAyR4B3a2mXJBYX lzH+/QqD4tNziN0OUfWojTQrqFeBz2GvvVoWshB6bck691dr3hlJJgUiGS+RIlCELv viYtVnRX5oPAZ80mN3Z0BgOQal7vyC30WifJuwofmQtNhc6ci73Rj8nyigjcdMv+4A 6wQ6eAtAQGwPEzt2l/6PboPLJB4ATw+frs8oM5wylpKiIE4K21S8/7eJCoHpMq9iIW AFqUvUyrE2NNQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C10F74426B7; Fri, 8 Sep 2023 11:42:09 -0400 (EDT) Original-Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 633E11201C6; Fri, 8 Sep 2023 11:42:09 -0400 (EDT) In-Reply-To: (=?windows-1252?Q?=22Jo=E3o_T=E1vora=22's?= message of "Fri, 8 Sep 2023 07:55:08 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310338 Archived-At: >> > C-c C-c is "go to place mentioned in this hunk". It must not apply anything, >> > I have it most hardwired in my brain. >> Really? > Yes, really. Curious: I always use RET instead. I'm actually having a hard time remembering/imagining how/why we ended up binding `C-c C-c` to `diff-goto-source` in `diff-mode`. >> For me it's more like "finish this commit" or "send this email". > That too of course. But these are other modes, no? To me the "show diff during refactoring" is a different situation from cases like `vc-diff` or `C-x C-f foo.diff`: it's more like showing you all the details of your order before you confirm that you really want to do it. >> diff-apply-everything could work with "someone's patches" just as well. >> That's actually a reason to just add it to diff-mode. > I never said there wasn't. But don't touch C-c C-c please. Maybe we should start by removing that `C-c C-c` binding from `diff-mode` (users like you who really like it can re-add it easily). Stefan