From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master b2416d2c029 4/6: Don't load comp when installing an existing trampoline Date: Tue, 14 Nov 2023 09:07:15 -0500 Message-ID: References: <169952969842.2327.17551267288789292121@vcs2.savannah.gnu.org> <20231109113503.9890EC0C198@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40182"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 14 15:07:58 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2u56-000ABO-EX for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Nov 2023 15:07:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2u4Z-0006pi-Mo; Tue, 14 Nov 2023 09:07:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2u4X-0006p1-DH for emacs-devel@gnu.org; Tue, 14 Nov 2023 09:07:21 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2u4V-0001TL-Bb; Tue, 14 Nov 2023 09:07:20 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9D8111000AD; Tue, 14 Nov 2023 09:07:16 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1699970836; bh=5HsjHGxNwnlr3Vhk24YwQNshz/8qbehmxX/Cqa/7I/s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=e7KN2XHt/lUzAOyVaWWJV0JBslzyNAcFiFEZZFFMRefn3XNpcbA49a2CrSqteDfuw BuNwgrwMQvuJtjyMBvwNjyWP0ar2x7tpHOnVV3Foa5DZKKsrMRjdJHuTzpfaqsLtp/ KiTWOG87vg3KbLZpw8S8dqzVnN51MVM2cmVzJ1rstW40i1ilOlUAN3j3dTS/lpBfCB Y0QAFvjs88K5tpSNOLA3dXmmGUAzfY9H6J+pBiOA3zPKmg5L3D39TntP6Qnp+F5rcS ISyqt3xhw08R3DlThW0TZeVuXAsAam17iL5JRbBaGgjDcScQU3K8coJYDTUjMDV72G kzHw6gLwtEq+w== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F2B57100043; Tue, 14 Nov 2023 09:07:15 -0500 (EST) Original-Received: from pastel (unknown [45.72.227.120]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D1E5F1202C0; Tue, 14 Nov 2023 09:07:15 -0500 (EST) In-Reply-To: (Andrea Corallo's message of "Tue, 14 Nov 2023 04:33:03 -0500") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312731 Archived-At: >> - The `declare-function` should be moved to right after (require >> 'comp-run), i.e. when we do know that the function should be available >> and it will thus silence only spurious warnings. > > Ack will do, out of curiosity what is the downside of having the > declare-function at top level? I thought is there to silence a compile > time warning (and thus the branch is inserted in should not play a > role). If you call that function from elsewhere in the file, there will be no compilation warning, even though the call may error at run time because `comp-run` wasn't loaded. By moving the `declare-function` you make sure only those warnings that you know for sure are spurious (because we just did `(require 'comp-run)`) will get silenced. > As mentioned in the other thread I fear I don't remeber the answer to > those quesitons. The best we can do is to remove the call and test > Emacs to find if there's still a good reason. Then let's remove it in `master`. This way, if it's needed we'll get to see why/when and we'll be able to at the very least add a good comment, or maybe replace it with a better solution. Stefan