From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/ebdb f7b50402cf: Final round of compiler quieting Date: Thu, 14 Dec 2023 21:36:54 -0500 Message-ID: References: <169810882764.9789.14002053467217676494@vcs2.savannah.gnu.org> <20231024005348.35660C09BE2@vcs2.savannah.gnu.org> <87r0jogti2.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9455"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 15 03:37:52 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rDy5H-0002Ka-Vt for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Dec 2023 03:37:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDy4X-0007K0-Qn; Thu, 14 Dec 2023 21:37:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDy4U-0007Jn-Nx for emacs-devel@gnu.org; Thu, 14 Dec 2023 21:37:03 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDy4P-0007j2-PF for emacs-devel@gnu.org; Thu, 14 Dec 2023 21:37:02 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 47126100068; Thu, 14 Dec 2023 21:36:56 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1702607815; bh=k5ndyrVJnSZ7nGOjSpx63Qa7oCXMUMt8pEYysZAtAso=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XxEtLsdUN1J8U+Pe1e5a/8FV3KULkwnx4jairj4Jo5hG0CdYpwAJaml5YDqF5Z43h PtOcVW4/nR0wDZXpW+H920hWJXYljWXufD5Qd5QidcjR9Ci0SdmfeSaapOu3bAhXzJ Csi/OzTixqsWBRRJynHXfFjWHzQlIgA/Wv3oYDnqFrIvMwD3X1K2wmZN+u5J8eM8L/ IWQNV1QfZ13GUG1vV5JTq6SO1UN3PQU2lYfFvlsXxpvVz23ia7zNYueHIXCXXDkiN3 DZwenFzwpvy6tCi5z+XbMyIHDSW38TOfxe/0p4oiTo7bgVMThe+lR5dU1b5c6G3aR2 tEeRyD0oEtz/Q== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 14F07100033; Thu, 14 Dec 2023 21:36:55 -0500 (EST) Original-Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E292F1201A4; Thu, 14 Dec 2023 21:36:54 -0500 (EST) In-Reply-To: <87r0jogti2.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 14 Dec 2023 17:11:01 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313839 Archived-At: > I'm finally getting to push this code! I decided that ebdb-add-to-list > simply wasn't necessary -- there were hardly any cases where the element > test was meaningful, and otherwise this could just be `ebdb-pushnew' > that delegates to `cl-pushnew' with a :test. I'll keep > ebdb-remove-from-list, with your re-definition, but couldn't guess how > to rename it appropriately. `pop' isn't right, I suppose it could be > `ebdb-delete-from-list' since it uses delete under the hood -- otherwise > I don't see a clear convention in place, did you have something specific > in mind? No, sorry, nothing specific in mind, the choice is all yours, Stefan