From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69501: 30.0.50; customize-mode error with substring completion style Date: Thu, 14 Mar 2024 14:11:20 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22283"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69501@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 14 19:13:01 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rkpZb-0005bN-8T for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Mar 2024 19:13:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkpZ6-0007As-DP; Thu, 14 Mar 2024 14:12:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkpZ4-0007Ab-Dn for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2024 14:12:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rkpZ3-0008Ih-SR for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2024 14:12:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rkpZd-0005IR-Li for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2024 14:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2024 18:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69501 X-GNU-PR-Package: emacs Original-Received: via spool by 69501-submit@debbugs.gnu.org id=B69501.171043993120274 (code B ref 69501); Thu, 14 Mar 2024 18:13:01 +0000 Original-Received: (at 69501) by debbugs.gnu.org; 14 Mar 2024 18:12:11 +0000 Original-Received: from localhost ([127.0.0.1]:50589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkpYo-0005Gw-OY for submit@debbugs.gnu.org; Thu, 14 Mar 2024 14:12:11 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkpYn-0005Gi-2y for 69501@debbugs.gnu.org; Thu, 14 Mar 2024 14:12:09 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 36C66442D9D; Thu, 14 Mar 2024 14:11:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1710439881; bh=XB9nI+o5pVzqDwksZ3TapZ5lJDit4qOv95a2plVqO3E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WebXEqTR6ADgOIgbKlvsAIyrPkMn8nNFLeboNfjCAVfSI6xqQFBTJg3C0mP1Dd5Kf gwX2Y/8k3YHZ6NXe7hwap+cjbroNI5TaSwd+B04oEeJDcxL2yr5dQKIwbqyucFgRtH RL/qVe7ljVN63DuDWPDDVBfFX7ZbqdfO9T3DgfYQDpgt47dwdGdKzf0uszR4wVNLMm GOkwPpZocKYqoJfv9BwAFc1vC6mlcbbKGHTRbJAMc854dGR+mNnhMZI7csCv68iHpJ 7eT0g9DEJaekO4/yOE9z+hjPKCSb7rZB5p7oXhSz9RDxsRWrtjUdrwu/awNwr05+XX 8rvRFf3wYjv8Q== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B450F442DA0; Thu, 14 Mar 2024 14:11:21 -0400 (EDT) Original-Received: from pastel (unknown [216.154.27.181]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 97BBF120198; Thu, 14 Mar 2024 14:11:21 -0400 (EDT) In-Reply-To: (Eshel Yaron's message of "Sat, 02 Mar 2024 09:59:48 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281630 Archived-At: > In general, let-binding completion-regexp-list around completing-read is > not a great idea IMO Definitely: `completion-regexp-list` should be let-bound only right around calls to `try/all-completions`. > because it affects recursive minibuffers as well. > So perhaps the best solution is to avoid doing that in customize-mode, > and to rely only on the predicate argument of completing-read instead? Indeed (see patch below). We should probably also change the completion code so it defends against such let-bindings of `completion-regexp-list`. Stefan diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el index 8fad51dc116..f004002333b 100644 --- a/lisp/cus-edit.el +++ b/lisp/cus-edit.el @@ -1159,14 +1159,15 @@ customize-mode for the MODE to customize." (interactive (list - (let ((completion-regexp-list '("-mode\\'")) - (group (custom-group-of-mode major-mode))) + (let ((group (custom-group-of-mode major-mode))) (if (and group (not current-prefix-arg)) major-mode (intern (completing-read (format-prompt "Mode" (and group major-mode)) obarray - 'custom-group-of-mode + (lambda (s) + (and (string-match "-mode\\'" (symbol-name s)) + (custom-group-of-mode s))) t nil nil (if group (symbol-name major-mode)))))))) (customize-group (custom-group-of-mode mode)))