From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: vc-annotate error, PATCH Date: Mon, 10 Apr 2006 18:27:46 -0400 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1144708181 4128 80.91.229.2 (10 Apr 2006 22:29:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 10 Apr 2006 22:29:41 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 11 00:29:40 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FT4t2-0006DQ-S3 for ged-emacs-devel@m.gmane.org; Tue, 11 Apr 2006 00:29:34 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FT4t2-0006n7-3e for ged-emacs-devel@m.gmane.org; Mon, 10 Apr 2006 18:29:32 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FT4rW-00067o-6x for emacs-devel@gnu.org; Mon, 10 Apr 2006 18:27:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FT4rS-00065V-Gz for emacs-devel@gnu.org; Mon, 10 Apr 2006 18:27:56 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FT4rS-00065O-AG for emacs-devel@gnu.org; Mon, 10 Apr 2006 18:27:54 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FT4wB-0006UL-6S for emacs-devel@gnu.org; Mon, 10 Apr 2006 18:32:47 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 9EA552CF463; Mon, 10 Apr 2006 18:27:51 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id CC392445C; Mon, 10 Apr 2006 18:27:46 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 96AF47159D; Mon, 10 Apr 2006 18:27:46 -0400 (EDT) Original-To: JD Smith In-Reply-To: (JD Smith's message of "Mon, 10 Apr 2006 15:00:13 -0700") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52623 Archived-At: > I looked into this further, and it turns out the ordering was correct, > but the `temp-buffer-show-function' was getting called before the > local variables were set, at the end of `with-output-to-temp-buffer'. > Since this in turns calls the auto-scaling display code, which > requires the local variables to be set, it fails. [...] > Below is a patch which does all this. Any objections to installing > it? Give it a try on a really old file, like subr.el. Thanks. The bug-fix part of the patch looks fine to me, thank you for tracking it down and please install it. I have no opinion on the colormap part of the code. Stefan