From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: vc-annotate error, PATCH
Date: Mon, 10 Apr 2006 18:27:46 -0400 [thread overview]
Message-ID: <jwvmzetoyof.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <pan.2006.04.10.22.00.13.145676@as.arizona.edu> (JD Smith's message of "Mon, 10 Apr 2006 15:00:13 -0700")
> I looked into this further, and it turns out the ordering was correct,
> but the `temp-buffer-show-function' was getting called before the
> local variables were set, at the end of `with-output-to-temp-buffer'.
> Since this in turns calls the auto-scaling display code, which
> requires the local variables to be set, it fails.
[...]
> Below is a patch which does all this. Any objections to installing
> it? Give it a try on a really old file, like subr.el.
Thanks. The bug-fix part of the patch looks fine to me, thank you for
tracking it down and please install it.
I have no opinion on the colormap part of the code.
Stefan
next prev parent reply other threads:[~2006-04-10 22:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 23:28 vc-annotate error JD Smith
2006-04-08 0:40 ` Kevin Rodgers
2006-04-08 1:36 ` JD Smith
2006-04-10 22:00 ` vc-annotate error, PATCH JD Smith
2006-04-10 22:27 ` Stefan Monnier [this message]
2006-04-10 22:59 ` JD Smith
2006-04-11 16:57 ` Richard Stallman
2006-04-11 18:02 ` JD Smith
2006-04-11 18:34 ` Dan Nicolaescu
2006-04-11 19:02 ` JD Smith
2006-04-11 19:19 ` Dan Nicolaescu
2006-04-12 17:09 ` Richard Stallman
2006-04-12 19:17 ` JD Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmzetoyof.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.