all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Alan Mackenzie <acm@muc.de>
Cc: David Koppelman <koppel@ece.lsu.edu>, emacs-devel@gnu.org
Subject: Re: hi-lock-mode doesn't work with emacs -Q.
Date: Fri, 15 Jun 2007 17:51:51 -0400	[thread overview]
Message-ID: <jwvmyz0ubxu.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20070615230452.GB3496@muc.de> (Alan Mackenzie's message of "Sat\, 16 Jun 2007 00\:04\:52 +0100")

> That patch will certainly make hi-lock work properly.  However, are you
> sure there is nothing else which can necessitate the enabling of the
> after-change function?  Also, there is nothing in the documentation
> forbidding a hacker from changing font-lock-keywords directly, which
> would cause font-lock to fail in other circumstances.

Indeed.

> It seems to me that this two-stage initialisation of f-l-mode brings a
> lot of complexity for very little gain - The f-l-change-function can
> never execute in the background and consume vast amounts of CPU usage.
> It can only ever be called for the current buffer, and if Font Lock is
> enabled, yet f-l-keywords hasn't been set, its runtime is negligible
> anyway.

The truth is: I haven't followed closely the introduction of font-core.el
and how font-lock-mode and font-lock-mode-internal interact.  So I'm not
sure which part of font-core.el's behavior is important and which isn't, so
I prefer to fix things from font-lock.el whre I understand the situation
a bit better.

> Or is there some good reason for this optimisation that I'm missing?  If
> not, I suggest that you simply remove this optimisation and always
> install the after-change function when f-l-mode is started.

That sounds great to me, but that amounts to removing font-core.el, so I'd
need to hear from those who introduced font-core.el.


        Stefan

      reply	other threads:[~2007-06-15 21:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-07  9:26 hi-lock-mode doesn't work with emacs -Q Alan Mackenzie
2007-06-07 13:22 ` Stefan Monnier
2007-06-08 11:11   ` Alan Mackenzie
2007-06-11 20:25 ` Stefan Monnier
2007-06-15 23:04   ` Alan Mackenzie
2007-06-15 21:51     ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvmyz0ubxu.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=koppel@ece.lsu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.