From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: vc-diff in non-VC buffer Date: Thu, 11 Oct 2007 10:39:22 -0400 Message-ID: References: <20071011120005.GD6804@thyrsus.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1192113630 9805 80.91.229.12 (11 Oct 2007 14:40:30 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 11 Oct 2007 14:40:30 +0000 (UTC) Cc: Juanma Barranquero , Richard Stallman , emacs-devel@gnu.org To: esr@thyrsus.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 11 16:40:27 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IfzCn-0008G3-UM for ged-emacs-devel@m.gmane.org; Thu, 11 Oct 2007 16:40:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IfzCh-00052X-VF for ged-emacs-devel@m.gmane.org; Thu, 11 Oct 2007 10:40:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IfzCe-0004zz-Py for emacs-devel@gnu.org; Thu, 11 Oct 2007 10:39:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IfzCd-0004y0-C3 for emacs-devel@gnu.org; Thu, 11 Oct 2007 10:39:56 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IfzCd-0004xd-2f for emacs-devel@gnu.org; Thu, 11 Oct 2007 10:39:55 -0400 Original-Received: from x-132-204-254-24.xtpr.umontreal.ca ([132.204.254.24] helo=ceviche.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IfzCY-0003rJ-7s; Thu, 11 Oct 2007 10:39:52 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 24E26B41BB; Thu, 11 Oct 2007 10:39:21 -0400 (EDT) In-Reply-To: <20071011120005.GD6804@thyrsus.com> (Eric S. Raymond's message of "Thu\, 11 Oct 2007 08\:00\:05 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80621 Archived-At: > So, for example, you can go to a top-level project directory and just > do C-x v = to look at the state of all changes beneath it, regardless > of whether you're actually visiting a controlled file. This is useful, > and I think many VC users would be (rightly) annoyed if they lost it. I don't know of such a feature, so I doubt many users would "miss it". The above scenario to me has the following problem: when you say "go to a top-level project directory", this can mean to do it by opening some arbitrary file in that top-level dir or by opening the dir with dired or with vc-dired. Of those 3 cases, I think the first case should not be supported. C-v x = from a file buffer should only apply to that file. The third should of course be supported and the one I expect people to use. The second doesn't matter: if it works, it's harmless and if it doesn't it's not serious either because the user could have used vc-dired instead. But it should only work if the corresponding dir is under some kind of version control, of course. > I'm testing code that errors out if you (a) have an empty fileset, and > (b) no files are registered immediately under default-directory. Juanma > thinks this will cover his use case. Don't check files: it should work in a BACKEND-controlled directory even if no files are currently registered in BACKEND yet. Check `responsible-p' or something like that (applied to the directory) instead. Stefan