From: Stefan Monnier <monnier@iro.umontreal.ca>
To: bug-gnu-emacs@gnu.org
Subject: Re: reindent-then-newline-and-indent doesn't indent properly in emacs 22.1
Date: Sun, 14 Oct 2007 15:48:21 -0400 [thread overview]
Message-ID: <jwvmyulh424.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: mailman.2040.1192368226.18990.bug-gnu-emacs@gnu.org
> --- lisp/simple.el.orig 2007-05-27 16:35:51.000000000 +0200
> +++ lisp/simple.el 2007-10-14 15:21:13.000000000 +0200
> @@ -618,7 +618,8 @@
> (indent-according-to-mode))
> (defun reindent-then-newline-and-indent ()
> - "Reindent current line, insert newline, then indent the new line.
> + "Reindent current line, insert newline deleting trailing spaces or tabs,
> +then indent the new line.
> Indentation of both lines is done according to the current major mode,
> which means calling the current value of `indent-line-function'.
> In programming language modes, this is the same as TAB.
> @@ -631,8 +632,12 @@
> (newline)
> (save-excursion
> (goto-char pos)
> - (indent-according-to-mode)
> - (delete-horizontal-space t))
> + ;; Beware of indentation functions moving point.
> + (save-excursion
> + (indent-according-to-mode))
> + ;; Delete all trailing spaces or tabs introduced by the newline command
> + ;; or the new indentation. 0 is for no space.
> + (just-one-space 0))
> (indent-according-to-mode)))
> (defun quoted-insert (arg)
The patch looks OK w.r.t wrapping indent-according-to-mode in save-excursion
(indeed I do expect all indentation functions to "preserve" point but it's
not stated anywhere, so I think both reindent-then-newline-and-indent and
indent-to-left-margin are at fault here).
But I do not understand why you replaced delete-horizontal-space with
just-one-space.
Stefan
next prev parent reply other threads:[~2007-10-14 19:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 23:02 reindent-then-newline-and-indent doesn't indent properly in emacs 22.1 nuxdoors
2007-10-13 8:40 ` martin rudalics
2007-10-13 22:24 ` nuxdoors
2007-10-14 13:23 ` nuxdoors
2007-10-14 18:26 ` martin rudalics
[not found] ` <mailman.2040.1192368226.18990.bug-gnu-emacs@gnu.org>
2007-10-14 19:48 ` Stefan Monnier [this message]
2007-10-16 15:19 ` Stefan Monnier
2007-10-15 1:37 ` Richard Stallman
2007-10-16 0:07 ` nuxdoors
2007-10-16 19:09 ` Richard Stallman
2007-10-16 20:39 ` nuxdoors
[not found] ` <E1Ii13p-0002HF-Q4@fencepost.gnu.org>
2007-10-19 1:07 ` nuxdoors
2007-10-14 12:46 ` nuxdoors
2007-10-15 1:37 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmyulh424.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.