* message-setup-fill-variables, mm-string-to-multibyte (was: Changes to emacs/lisp/gnus/message.el, v)
[not found] <E1Imatx-0003Si-MI@cvs.savannah.gnu.org>
@ 2007-10-29 22:01 ` Reiner Steib
2007-10-30 2:04 ` message-setup-fill-variables, mm-string-to-multibyte Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: Reiner Steib @ 2007-10-29 22:01 UTC (permalink / raw)
To: Stefan Monnier; +Cc: ding, emacs-devel
On Mon, Oct 29 2007, Stefan Monnier committed:
> --- message.el 28 Oct 2007 09:18:27 -0000 1.123
> +++ message.el 29 Oct 2007 20:07:57 -0000 1.124
> @@ -2877,6 +2877,8 @@
> ;; solution would be not to use `define-derived-mode', and run
> ;; `text-mode-hook' ourself at the end of the mode.
> ;; -- Per Abrahamsen <abraham@dina.kvl.dk> Date: 2001-10-19.
> + ;; This kludge is unneeded in Emacs>=21 since define-derived-mode is
> + ;; now careful to run parent hooks after the body. --Stef
> (when auto-fill-function
> (setq auto-fill-function normal-auto-fill-function)))
Then we could remove it (unless XEmacs 21.4) in No Gnus (Emacs 23).
> @@ -4952,7 +4954,7 @@
> ;; Check for control characters.
> (message-check 'control-chars
> (if (re-search-forward
> - (mm-string-as-multibyte "[\000-\007\013\015-\032\034-\037\200-\237]")
> + (mm-string-to-multibyte "[\000-\007\013\015-\032\034-\037\200-\237]")
> nil t)
> (y-or-n-p
> "The article contains control characters. Really post? ")
Should this go to Emacs 22 (v5-10) as well? (Is it a bug fix?)
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: message-setup-fill-variables, mm-string-to-multibyte
2007-10-29 22:01 ` message-setup-fill-variables, mm-string-to-multibyte (was: Changes to emacs/lisp/gnus/message.el, v) Reiner Steib
@ 2007-10-30 2:04 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2007-10-30 2:04 UTC (permalink / raw)
To: emacs-devel; +Cc: ding
>> @@ -4952,7 +4954,7 @@
>> ;; Check for control characters.
>> (message-check 'control-chars
>> (if (re-search-forward
>> - (mm-string-as-multibyte "[\000-\007\013\015-\032\034-\037\200-\237]")
>> + (mm-string-to-multibyte "[\000-\007\013\015-\032\034-\037\200-\237]")
>> nil t)
>> (y-or-n-p
>> "The article contains control characters. Really post? ")
> Should this go to Emacs 22 (v5-10) as well? (Is it a bug fix?)
I don't think it's really a bug-fix. The behavior of the two should be
identical in this particular case, so it's more philosophical.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-30 2:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1Imatx-0003Si-MI@cvs.savannah.gnu.org>
2007-10-29 22:01 ` message-setup-fill-variables, mm-string-to-multibyte (was: Changes to emacs/lisp/gnus/message.el, v) Reiner Steib
2007-10-30 2:04 ` message-setup-fill-variables, mm-string-to-multibyte Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.