From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Fixing numerous `message' bugs.. Date: Thu, 06 Dec 2007 11:49:07 -0500 Message-ID: References: <87myso8yrs.fsf@marie.gnufans.net> <87ve7b4xt6.fsf@marie.gnufans.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1196959770 25112 80.91.229.12 (6 Dec 2007 16:49:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 6 Dec 2007 16:49:30 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dave Goel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 06 17:49:39 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J0Jut-0001LT-64 for ged-emacs-devel@m.gmane.org; Thu, 06 Dec 2007 17:49:39 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J0Juc-0007C3-33 for ged-emacs-devel@m.gmane.org; Thu, 06 Dec 2007 11:49:22 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J0JuW-00078h-RG for emacs-devel@gnu.org; Thu, 06 Dec 2007 11:49:16 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J0JuV-00077b-FR for emacs-devel@gnu.org; Thu, 06 Dec 2007 11:49:16 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J0JuV-00077J-3d for emacs-devel@gnu.org; Thu, 06 Dec 2007 11:49:15 -0500 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J0JuT-00032S-Mw for emacs-devel@gnu.org; Thu, 06 Dec 2007 11:49:13 -0500 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id AA0722CF785; Thu, 6 Dec 2007 11:49:12 -0500 (EST) Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 0DC4A3FE1; Thu, 6 Dec 2007 11:49:08 -0500 (EST) Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id EDC356CAB3; Thu, 6 Dec 2007 11:49:07 -0500 (EST) In-Reply-To: <87ve7b4xt6.fsf@marie.gnufans.net> (Dave Goel's message of "Thu, 06 Dec 2007 11:01:25 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84800 Archived-At: >> This will automatically fix all such code. The only problem with it is >> that there is > .. (in principle).. Not just in principle. A quick "grep '(message.*%%' lisp/**/*.el" shows a fair number. >> code out there that calls message with a single arg and expects >> `message' to dequote "%%" into "%". > Indeed. We should leave `message' itelf alone. Actually, I'd prefer changing message, but I already suggested it and it was rejected (maybe I even installed the change and then backed it out, can't remember). The problem I wanted to address with this change was not just to fix existing code but to try and avoid such bugs in the future as well. Stefan