From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: emacs-devel@gnu.org
Subject: Re: isearch-push-state
Date: Tue, 11 Mar 2008 13:55:08 -0400 [thread overview]
Message-ID: <jwvmyp5kv6q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <878x0q1n2q.fsf_-_@jurta.org> (Juri Linkov's message of "Mon, 10 Mar 2008 19:59:57 +0200")
Thanks Juri. I'm not sure I understand what you said: are you saying
that those extra state-pushes are just unnecessary or are they
really harmful? It seems they are harmful w.r.t the new
failed-search-highlight thingy, but shouldn't the failed-search-highlight
thingy try to pop several states until findind one that
does succeed?
I'm not sure I like the idea that "spurious" state pushes can really
be harmful.
This said, wherever you remove those pushes, please replace them with
a comment mentioning that it was there and why you think
it's unnecessary.
Stefan
> Index: lisp/isearch.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/isearch.el,v
> retrieving revision 1.313
> diff -c -r1.313 isearch.el
> *** lisp/isearch.el 28 Feb 2008 01:57:42 -0000 1.313
> --- lisp/isearch.el 10 Mar 2008 17:56:09 -0000
> ***************
> *** 1096,1104 ****
> ;; Only the string actually used should be saved.
> ))
> - ;; Push the state as of before this C-s.
> - (isearch-push-state)
> -
> ;; Reinvoke the pending search.
> (isearch-search)
> (isearch-push-state)
> --- 1081,1086 ----
> ***************
> *** 1895,1904 ****
> (if search-ring-update
> (progn
> (isearch-search)
> (isearch-update))
> ! (isearch-edit-string)
> ! )
> ! (isearch-push-state))
> (defun isearch-ring-advance ()
> "Advance to the next search string in the ring."
> --- 1887,1895 ----
> (if search-ring-update
> (progn
> (isearch-search)
> + (isearch-push-state)
> (isearch-update))
> ! (isearch-edit-string)))
> (defun isearch-ring-advance ()
> "Advance to the next search string in the ring."
> --
> Juri Linkov
> http://www.jurta.org/emacs/
next prev parent reply other threads:[~2008-03-11 17:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-08 14:38 First two elements of search-ring shown twice in minibuffer when using M-p multiple times? Tobias Bading
2008-03-08 15:18 ` Juri Linkov
2008-03-09 21:59 ` Juri Linkov
2008-03-10 14:31 ` Stefan Monnier
2008-03-10 17:12 ` Word search (was: First two elements of search-ring shown twice in minibuffer when using M-p multiple times?) Juri Linkov
2008-03-10 18:34 ` Word search Stefan Monnier
2008-03-10 22:38 ` Juri Linkov
2008-03-11 18:47 ` Stefan Monnier
2008-03-12 0:35 ` Juri Linkov
2008-03-12 1:49 ` Stefan Monnier
2008-03-12 10:38 ` Juri Linkov
2008-03-12 14:09 ` Stefan Monnier
2008-03-12 17:51 ` Richard Stallman
2008-03-11 20:24 ` Richard Stallman
2008-03-12 0:37 ` Juri Linkov
2008-03-12 17:51 ` Richard Stallman
2008-03-13 2:08 ` Juri Linkov
2008-03-13 22:24 ` Richard Stallman
2008-03-13 10:55 ` René Kyllingstad
2008-03-14 1:08 ` Juri Linkov
2008-03-12 19:18 ` Drew Adams
2008-03-13 1:06 ` Richard Stallman
2008-03-13 2:17 ` Juri Linkov
2008-03-13 22:24 ` Richard Stallman
2008-03-10 16:36 ` First two elements of search-ring shown twice in minibuffer when using M-p multiple times? Tobias Bading
2008-03-10 16:55 ` Juri Linkov
2008-03-10 17:59 ` isearch-push-state (was: First two elements of search-ring shown twice in minibuffer when using M-p multiple times?) Juri Linkov
2008-03-11 17:55 ` Stefan Monnier [this message]
2008-03-12 10:36 ` isearch-push-state Juri Linkov
2008-03-12 14:07 ` isearch-push-state Stefan Monnier
2008-03-10 18:28 ` First two elements of search-ring shown twice in minibuffer when using M-p multiple times? Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmyp5kv6q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.