From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Eric Schulte" <schulte.eric@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: .dir-locals.el
Date: Thu, 08 Jan 2009 11:30:46 -0500 [thread overview]
Message-ID: <jwvmye1g46t.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87hc4ak6b9.fsf@gmail.com> (Eric Schulte's message of "Wed, 07 Jan 2009 16:08:42 -0800")
> (defadvice cd (after dir-locals-on-cd activate)
> "Apply the variables defined in .dir-locals.el when changing
> into and outof a directory in eshell."
> (hack-dir-local-variables))
If you do
(defadvice cd (after dir-locals-on-cd activate)
(let ((buffer-file-name default-directory))
(hack-dir-local-variables)))
it might get you a bit further. But note that it still won't do what
you want: it'll only give you file-local-variables-alist, which you then
have to apply to the buffer.
Furthermore, before applying it, you'll need to un-apply those settings
you had applied earlier and which were relevant to the directory in
which you were before `cd'.
So you'll want something like (100% guaranteed untested)
(defadvice cd (around dir-locals-on-cd activate)
(while eshell-previous-values
(let ((x (pop eshell-previous-values)))
(if (consp x)
(set (car x) (cdr x))
(kill-local-variable x))))
ad-do-it
(let ((buffer-file-name default-directory))
(hack-dir-local-variables))
(dolist (x file-local-variables-alist)
(let ((var (car x))
(val (cdr x)))
(push (if (buffer-local-p var)
(cons var (symbol-value var))
var)
eshell-previous-values)
(set (make-local-variable var) val))))
> Is there a supported way to do this?
Not.
> If not should I write a new function for this?
Your call.
> If so should it be included in the dir-locals.el functionality?
Not sure.
> If not is there a reason to only allow setting local variables for
> buffers visiting files?
It's not obviously clear that applying .dir-locals.el to eshell like you
suggest is a good idea. It seems consistent with the idea that
"cd /ssh:foo:" ends up behaving like "ssh foo", tho.
Maybe your suggestion to change hack-dir-local-variables so it uses
default-directory rather than buffer-file-name is a good one. It seems
like it would be a safe change and would allow the above advice to feel
a tiny bit less hackish.
Stefan
next prev parent reply other threads:[~2009-01-08 16:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-26 15:18 .dir-locals.el Eli Zaretskii
2008-12-26 16:04 ` .dir-locals.el Eli Zaretskii
2008-12-27 2:39 ` .dir-locals.el Miles Bader
2008-12-27 9:33 ` .dir-locals.el Eli Zaretskii
2008-12-27 16:43 ` .dir-locals.el Juanma Barranquero
2008-12-27 17:13 ` .dir-locals.el Dan Nicolaescu
2008-12-27 19:04 ` .dir-locals.el Eli Zaretskii
2009-01-08 0:08 ` .dir-locals.el Eric Schulte
2009-01-08 3:04 ` .dir-locals.el Kevin Rodgers
2009-01-08 5:53 ` .dir-locals.el Eric Schulte
2009-01-08 16:30 ` Stefan Monnier [this message]
2009-01-08 22:45 ` .dir-locals.el Juri Linkov
2009-01-09 3:14 ` .dir-locals.el Stefan Monnier
2009-01-09 0:30 ` .dir-locals.el Eric Schulte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmye1g46t.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=schulte.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.