From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: 2604@emacsbugs.donarmstrong.com
Subject: bug#2604: 23.0.91; key bindings in vc-annotate incompatible w/ Emacs 22
Date: Tue, 10 Mar 2009 22:06:24 -0400 [thread overview]
Message-ID: <jwvmybsg6fo.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <200903102130.n2ALUVW9029254@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Tue, 10 Mar 2009 14:30:31 -0700 (PDT)")
>> > --8<---------------cut here---------------start------------->8---
>> > --- vc-annotate.el 09 Jan 2009 09:52:59 +0100 1.7
>> > +++ vc-annotate.el 09 Mar 2009 20:35:28 +0100
>> > @@ -506,7 +506,10 @@
>> > "Visit the diff of the revision at line from its previous revision for all files in the changeset."
>> > (interactive)
>> > (when (eq 'file (vc-call-backend vc-annotate-backend 'revision-granularity))
>> > - (error "The %s backend does not support changeset diffs" vc-annotate-backend))
>> > + (error
>> > + (substitute-command-keys "The %s backend does not support changeset diffs. \
>> > +Use \\[vc-annotate-show-diff-revision-at-line] to diff this file.")
>> > + vc-annotate-backend))
>> > (vc-annotate-show-diff-revision-at-line-internal nil))
>>
>> We could also fallback to the single-file diff code when the fileset is
>> a singleton.
> This is vc-annotate, the fileset (if you are referring to the vc.el
> notion of fileset) is always singleton.
I meant changeset. But, yes, I now realize that we don't know the size
of the changeset, so we can't do any better than what we do now.
Stefan
next prev parent reply other threads:[~2009-03-11 2:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-08 23:06 bug#2604: 23.0.91; key bindings in vc-annotate incompatible w/ Emacs 22 Reiner Steib
2009-03-09 17:48 ` Dan Nicolaescu
2009-03-09 19:57 ` Reiner Steib
2009-03-10 0:42 ` Dan Nicolaescu
2009-03-10 0:59 ` Stefan Monnier
2009-03-10 21:30 ` Dan Nicolaescu
2009-03-11 2:06 ` Stefan Monnier [this message]
2009-03-17 1:13 ` Dan Nicolaescu
2009-03-09 17:49 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmybsg6fo.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=2604@emacsbugs.donarmstrong.com \
--cc=dann@ics.uci.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.