From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 4879@emacsbugs.donarmstrong.com
Subject: bug#4879: Crash in xmenu_show
Date: Sat, 07 Nov 2009 22:43:01 -0500 [thread overview]
Message-ID: <jwvmy2xk7i1.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <87aayzchne.fsf@stupidchicken.com> (Chong Yidong's message of "Fri, 06 Nov 2009 19:17:41 -0500")
>>>>> "Chong" == Chong Yidong <cyd@stupidchicken.com> writes:
>> Program received signal SIGSEGV, Segmentation fault.
>> [Switching to Thread 0x7fb3746be7a0 (LWP 19530)]
>> 0x00000000004701c7 in xmenu_show (f=0x11c46e0, x=227, y=29, for_click=1, keymaps=1, title=12708355, error=0x7fff7c6ed8c0) at xmenu.c:2735
>> 2735 bcopy (SDATA (item_name), item_data,
> The problem is that
> XVECTOR (menu_items)->contents[i + MENU_ITEMS_ITEM_EQUIV_KEY];
> is now a symbol, but the code (here and in a couple of other places in
> xmenu.c, and maybe elsewhere) assumes that it's a string or nil.
> It's simple to "fix" by adding an additional check for symbols as menu
> descriptors, but we need to understand why the situation has changed.
> Stefan, I'm 99% sure this was caused by your keymap changes around
> 2009-09-11. Could you please debug them?
Hmm... not sure how it relates, but I see one possible trouble spot.
Does the patch below help?
Stefan
--- keyboard.c.~1.1016.~ 2009-10-24 22:39:01.000000000 -0400
+++ keyboard.c 2009-11-07 22:41:50.000000000 -0500
@@ -8118,6 +8118,8 @@
tem = concat2 (build_string (" "), tem);
/* tem = concat3 (build_string (" ("), tem, build_string (")")); */
}
+ else
+ tem = Qnil;
}
next parent reply other threads:[~2009-11-08 3:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87aayzchne.fsf@stupidchicken.com>
2009-11-08 3:43 ` Stefan Monnier [this message]
2009-11-08 5:02 ` bug#4879: Crash in xmenu_show Chong Yidong
2009-11-08 15:07 ` Stefan Monnier
2009-11-09 0:49 ` Juri Linkov
2009-11-06 10:49 Juri Linkov
2009-11-06 11:50 ` Eli Zaretskii
2009-11-06 15:11 ` Jan Djärv
2009-11-06 21:06 ` Juri Linkov
2009-11-06 21:10 ` Juri Linkov
2009-11-07 9:03 ` Eli Zaretskii
2009-11-11 15:11 ` Kevin Rodgers
2009-11-11 16:39 ` Stefan Monnier
2009-11-14 4:39 ` Glenn Morris
2009-11-14 7:10 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmy2xk7i1.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=4879@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.