bug#5119: ruby-mode binds TAB

bug#5119: ruby-mode binds TAB

[Lennart Borgman]

It binds TAB to ruby-indent-line. That is against the rules. ;-)

It should instead leave this unbound and do

  (set (make-local-variable 'indent-line-function)
       'ruby-indent-line)

Index: ruby-mode.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/ruby-mode.el,v
retrieving revision 1.11
diff -c -r1.11 ruby-mode.el
*** ruby-mode.el	26 Oct 2009 06:43:41 -0000	1.11
--- ruby-mode.el	4 Dec 2009 03:35:16 -0000
***************
*** 166,172 ****
      (define-key map (kbd "M-C-n") 'ruby-end-of-block)
      (define-key map (kbd "M-C-h") 'ruby-mark-defun)
      (define-key map (kbd "M-C-q") 'ruby-indent-exp)
-     (define-key map (kbd "TAB")   'ruby-indent-line)
      (define-key map (kbd "C-M-h") 'backward-kill-word)
      (define-key map (kbd "C-j")   'reindent-then-newline-and-indent)
      (define-key map (kbd "C-m")   'newline)
--- 166,171 ----
***************
*** 1390,1395 ****
--- 1389,1396 ----
    (setq major-mode 'ruby-mode)
    (ruby-mode-variables)

+   (set (make-local-variable 'indent-line-function)
+        'ruby-indent-line)
    (set (make-local-variable 'imenu-create-index-function)
         'ruby-imenu-create-index)
    (set (make-local-variable 'add-log-current-defun-function)

bug#5119: ruby-mode binds TAB

[Stefan Monnier]

> It binds TAB to ruby-indent-line. That is against the rules. ;-)
> It should instead leave this unbound and do

>   (set (make-local-variable 'indent-line-function)
>        'ruby-indent-line)

Yes, please,


        Stefan

bug#5119:

[Deniz Dogan]

This bug was merged with another bug which was originally submitted in
March 30 2009 and no one seems to have any objections.

Could anyone apply the patch?

-- 
Deniz Dogan

bug#5119:

[Drew Adams]

> This bug was merged with another bug which was originally submitted in
> March 30 2009 and no one seems to have any objections.
> 
> Could anyone apply the patch?

Please mention the bug it was merged with in your mail, so someone who might be
interested need not go to the bug tracker to look up this info. Thx.

bug#5119:

[Deniz Dogan]

2010/6/27 Drew Adams <drew.adams@oracle.com>:
>> This bug was merged with another bug which was originally submitted in
>> March 30 2009 and no one seems to have any objections.
>>
>> Could anyone apply the patch?
>
> Please mention the bug it was merged with in your mail, so someone who might be
> interested need not go to the bug tracker to look up this info. Thx.
>
>

It was merged with #2820 named "23.0.91; ruby-mode binds keys it
probably shouldn't".

-- 
Deniz Dogan

bug#5119: ruby-mode binds TAB

[Chong Yidong]

> It binds TAB to ruby-indent-line. That is against the rules. ;-)
>
> It should instead leave this unbound and do
>
>   (set (make-local-variable 'indent-line-function)
>        'ruby-indent-line)

Checked in, thanks.