bug#6222: Shouldn't f1 in isearch-mode be help?

bug#6222: Shouldn't f1 in isearch-mode be help?

[Lennart Borgman]

C-h gives isearch help in isearch, but f1 does not. Should not both do
the same for consistency?

And should not `help-char' (or [help]) be used instead of C-h in the code?

The doc string for isearch does not mention that you now have this
good help for isearch during isearch. Shouldn't it do that?


BTW: My bad memory can't find a variable that is holding both C-h and
f1. Wasn't there such a variable?

bug#6222: Shouldn't f1 in isearch-mode be help?

[Juri Linkov]

> C-h gives isearch help in isearch, but f1 does not. Should not both do
> the same for consistency?
>
> And should not `help-char' (or [help]) be used instead of C-h in the code?
>
> The doc string for isearch does not mention that you now have this
> good help for isearch during isearch. Shouldn't it do that?
>
> BTW: My bad memory can't find a variable that is holding both C-h and
> f1. Wasn't there such a variable?

There is no such variable.  E.g. in help.el help bindings are repeated
three times:

    (define-key map (char-to-string help-char) 'help-for-help)
    (define-key map [help] 'help-for-help)
    (define-key map [f1] 'help-for-help)

and

    (define-key global-map (char-to-string help-char) 'help-command)
    (define-key global-map [help] 'help-command)
    (define-key global-map [f1] 'help-command)

-- 
Juri Linkov
http://www.jurta.org/emacs/

bug#6222: Shouldn't f1 in isearch-mode be help?

[Lennart Borgman]

On Thu, May 20, 2010 at 2:20 AM, Juri Linkov <juri@jurta.org> wrote:
>> C-h gives isearch help in isearch, but f1 does not. Should not both do
>> the same for consistency?
>>
>> And should not `help-char' (or [help]) be used instead of C-h in the code?
>>
>> The doc string for isearch does not mention that you now have this
>> good help for isearch during isearch. Shouldn't it do that?
>>
>> BTW: My bad memory can't find a variable that is holding both C-h and
>> f1. Wasn't there such a variable?
>
> There is no such variable.  E.g. in help.el help bindings are repeated
> three times:
>
>    (define-key map (char-to-string help-char) 'help-for-help)
>    (define-key map [help] 'help-for-help)
>    (define-key map [f1] 'help-for-help)
>
> and
>
>    (define-key global-map (char-to-string help-char) 'help-command)
>    (define-key global-map [help] 'help-command)
>    (define-key global-map [f1] 'help-command)


Thanks, I see. But shouldn't isearch do the same then?

What about having a function in help.el for defining a binding for all
three possibilities? Something like

  (defun help-define-help-keys (map command)
    (define-key map (char-to-string help-char) command)
    (define-key map [help] command)
    (define-key map [f1] command))

bug#6222: Shouldn't f1 in isearch-mode be help?

[Juri Linkov]

>>    (define-key global-map (char-to-string help-char) 'help-command)
>>    (define-key global-map [help] 'help-command)
>>    (define-key global-map [f1] 'help-command)
>
> Thanks, I see. But shouldn't isearch do the same then?

I agree that it should:

=== modified file 'lisp/isearch.el'
--- lisp/isearch.el	2010-04-16 01:30:37 +0000
+++ lisp/isearch.el	2010-05-20 00:38:21 +0000
@@ -461,6 +461,9 @@ (defvar isearch-mode-map
     (define-key map    "\C-y" 'isearch-yank-line)
 
     (define-key map "\C-h" isearch-help-map)
+    (define-key map (char-to-string help-char) isearch-help-map)
+    (define-key map [help] isearch-help-map)
+    (define-key map [f1] isearch-help-map)
 
     (define-key map "\M-n" 'isearch-ring-advance)
     (define-key map "\M-p" 'isearch-ring-retreat)

> What about having a function in help.el for defining a binding for all
> three possibilities? Something like
>
>   (defun help-define-help-keys (map command)
>     (define-key map (char-to-string help-char) command)
>     (define-key map [help] command)
>     (define-key map [f1] command))

I'd rather remap all them to one key.

-- 
Juri Linkov
http://www.jurta.org/emacs/

bug#6222: Shouldn't f1 in isearch-mode be help?

[Lennart Borgman]

On Thu, May 20, 2010 at 2:38 AM, Juri Linkov <juri@jurta.org> wrote:
>>>    (define-key global-map (char-to-string help-char) 'help-command)
>>>    (define-key global-map [help] 'help-command)
>>>    (define-key global-map [f1] 'help-command)
>>
>> Thanks, I see. But shouldn't isearch do the same then?
>
> I agree that it should:

Fine, thanks.

>> What about having a function in help.el for defining a binding for all
>> three possibilities? Something like
>>
>>   (defun help-define-help-keys (map command)
>>     (define-key map (char-to-string help-char) command)
>>     (define-key map [help] command)
>>     (define-key map [f1] command))
>
> I'd rather remap all them to one key.

I don't understand, but that is just because I do not know the details
of remap I guess. Otherwise it sounds reasonable.

bug#6222: Shouldn't f1 in isearch-mode be help?

[Stefan Monnier]

> BTW: My bad memory can't find a variable that is holding both C-h and
> f1. Wasn't there such a variable?

You're thinking of help-char and help-event-list.


        Stefan

bug#6222: Shouldn't f1 in isearch-mode be help?

[Juri Linkov]

Patch installed.

-- 
Juri Linkov
http://www.jurta.org/emacs/