From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#8926: 24.0.50; pcomplete regression Date: Thu, 30 Jun 2011 17:19:46 -0400 Message-ID: References: <87ei2j7lu6.fsf@gmail.com> <87tybdq2u6.fsf@gmail.com> <87ei2f3nw6.fsf@gmail.com> <87hb77jjr5.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1309470259 23166 80.91.229.12 (30 Jun 2011 21:44:19 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 30 Jun 2011 21:44:19 +0000 (UTC) Cc: 8926@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 30 23:44:15 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QcP1v-0005FQ-Mn for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Jun 2011 23:44:11 +0200 Original-Received: from localhost ([::1]:55195 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcP1u-0001sc-ND for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Jun 2011 17:44:10 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:51457) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcOef-0003wQ-EX for bug-gnu-emacs@gnu.org; Thu, 30 Jun 2011 17:20:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcOeb-0007AQ-Ob for bug-gnu-emacs@gnu.org; Thu, 30 Jun 2011 17:20:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcOeb-00079G-8X for bug-gnu-emacs@gnu.org; Thu, 30 Jun 2011 17:20:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QcOeZ-0002HH-Ax; Thu, 30 Jun 2011 17:20:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jun 2011 21:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix notabug Original-Received: via spool by 8926-submit@debbugs.gnu.org id=B8926.13094687948737 (code B ref 8926); Thu, 30 Jun 2011 21:20:02 +0000 Original-Received: (at 8926) by debbugs.gnu.org; 30 Jun 2011 21:19:54 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QcOeQ-0002Gs-Lb for submit@debbugs.gnu.org; Thu, 30 Jun 2011 17:19:54 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QcOeO-0002Gg-R6 for 8926@debbugs.gnu.org; Thu, 30 Jun 2011 17:19:53 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAITnDE5MCqDH/2dsb2JhbABSp1t4x2yGMQSeToQr X-IronPort-AV: E=Sophos;i="4.65,454,1304308800"; d="scan'208";a="118218355" Original-Received: from 76-10-160-199.dsl.teksavvy.com (HELO pastel.home) ([76.10.160.199]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 30 Jun 2011 17:19:46 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 6BE845912D; Thu, 30 Jun 2011 17:19:46 -0400 (EDT) In-Reply-To: <87hb77jjr5.fsf@gmail.com> (Thierry Volpiatto's message of "Thu, 30 Jun 2011 19:45:34 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 30 Jun 2011 17:20:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47665 Archived-At: >>>> Yup. Because among the various completion cases, the case for "files" >>>> used to return a list and now returns a function. Both are valid >>>> completion tables. Any caller of pcomplete-completions should expect to >>>> receive a completion table and not just a list of strings. It may very >>>> well receive a list of strings (which is one kind of completion table), >>>> but it may just as well receive something else. >>> Yes i saw that, and it's what i didn't understand. >> >> BTW, the reason for the above change was not just to fix a bug when >> using pcomplete-completions-at-point but also so that partial-completion >> now works with pcomplete-entries (so you can "cd ~/e/e TAB" to go to >> ~/etc/emacs). > Yes, but the downside is now that it is hard to use by external > libraries outside the context of emacs shell/eshell. Presumably such code already handles completion tables, so having to handle a completion table rather than a list of strings shouldn't be that much of a problem. Calling `all-completions' shouldn't scare those authors. Stefan